Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Color scheme for disabled button #187

Closed
Tracked by #44
donyunardi opened this issue May 17, 2023 · 1 comment · Fixed by #252
Closed
Tracked by #44

Color scheme for disabled button #187

donyunardi opened this issue May 17, 2023 · 1 comment · Fixed by #252
Assignees
@chlebowa
Labels
blocked core enhancement good first issue Good for newcomers

Comments

@donyunardi
Copy link
Contributor

donyunardi commented May 17, 2023 •
edited
Loading

Felt like we can do better when the button is disabled (blue and grey just not pleasing to the eye).

image

image

Originally posted by @donyunardi in #186 (comment)
@lcd2yyz lcd2yyz mentioned this issue Jun 12, 2023
Closed
7 tasks
@chlebowa
Copy link
Contributor

chlebowa commented Aug 3, 2023 •
edited by donyunardi
Loading

Acceptance criteria:

Modify CSS of the buttons in the dialogs to ensure good contrast/readability.

@donyunardi donyunardi added the good first issue Good for newcomers label Sep 14, 2023
@donyunardi donyunardi mentioned this issue Oct 13, 2023
Open
10 tasks
@chlebowa chlebowa self-assigned this Feb 21, 2024
@chlebowa chlebowa mentioned this issue Feb 21, 2024
Merged
chlebowa added a commit that referenced this issue Feb 26, 2024
@chlebowa
187 color scheme for disabled button (#252)
6dccc8c 
Closes #187 

Updated background color of two buttons (anchor elements) identified by
_partial ids_ in disabled state.

The background color is `darkgrey` nad text color is `white`.


![image](https://github.com/insightsengineering/teal.reporter/assets/114988527/1c619023-b017-4fad-897c-ffb604e74ef4)

![image](https://github.com/insightsengineering/teal.reporter/assets/114988527/a0a49e05-5efc-4ad6-b5aa-9725c949411e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chlebowa chlebowa

Labels
blocked core enhancement good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

187 color scheme for disabled button insightsengineering/teal.reporter
3 participants
@donyunardi @lcd2yyz @chlebowa