-
-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change color of buttons in modals #186
Conversation
Code Coverage Summary
Diff against main
Results for commit: e7d5185 Minimum allowed coverage is ♻️ This comment has been updated with latest results |
Felt like we can do better when the button is disabled (blue and grey just not pleasing to the eye). How about we make these changes in teal.reporter/inst/css/Previewer.css Lines 10 to 15 in 67c71ea
To be like this: a.disabled {
color: white;
background-color:#6a98bf;
border-color: #6a98bf;
cursor: not-allowed;
pointer-events: none;
text-decoration: none;
} So now, the button looks like this when disabled: I'm keeping the color scheme (btn-primary) but just making it a bit lighter when disabled. |
I just read my comment again and realized that this might be out of scope from the main issue. |
@donyunardi I think the disabled color should be a new issue. Mostly because it needs more thought around how to adjust the color. While your suggested style changes look better, I wouldn't recommend using a color directly like #6a98bf. It may match the theme in the screenshot, but what if I use Bootswatch United? What if I define my own custom primary color? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested changes for issues. PR looks good.
Changes the colors of buttons in the various modals.
Fixes #179