Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor LBT07 layout to work with trim_levels_to_map #111

Closed
6 tasks done
anajens opened this issue Aug 27, 2021 · 5 comments · Fixed by #131 or #222
Closed
6 tasks done

Refactor LBT07 layout to work with trim_levels_to_map #111

anajens opened this issue Aug 27, 2021 · 5 comments · Fixed by #131 or #222

Comments

@anajens
Copy link
Contributor

anajens commented Aug 27, 2021

Redesign family of functions used to create LBT07 layout to work with rtables::trim_levels_to_map. Background issue (insightsengineering/rtables#203)

Rationale: improved speed, allow users to precisely control which combinations of levels among several categorical variables used in the layout should be displayed.

Note note all of the step above may be relevant for the layout. If an update is necessary, please add the PR link below.

@anajens
Copy link
Contributor Author

anajens commented Sep 10, 2021

Moving to sprint 29

@anajens anajens reopened this Sep 23, 2021
@anajens
Copy link
Contributor Author

anajens commented Sep 23, 2021

Not ready for October release so moving to SME backlog.

@imazubi
Copy link
Contributor

imazubi commented Oct 13, 2021

@anajens here should we start the work from the beginning so that we can make use of .spl_context and hence split_rows_by(var = ANRIND) with a map dataframe that only accepts high/lowvalues but not normal?

@anajens
Copy link
Contributor Author

anajens commented Oct 13, 2021

@imazubi yes I think it would be nice to see if you can update the design doc to take advantage of .spl_context for this layout.

@anajens
Copy link
Contributor Author

anajens commented Oct 13, 2021

@imazubi just a heads up I added the nsdl.tests checkbox to the task list above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants