Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-transform helpers default #251

Open
insin opened this issue Jan 31, 2017 · 1 comment
Open

runtime-transform helpers default #251

insin opened this issue Jan 31, 2017 · 1 comment

Comments

@insin
Copy link
Owner

insin commented Jan 31, 2017

The helpers default should probably be revisited.

These are the current defaults for runtime-transform, configured to let you use async/await:, pulling in the necessary runtime only when required:

  let runtimeTransformOptions = {
    helpers: false,
    polyfill: false,
    regenerator: true,
  }

For apps, I think it makes sense to have helpers on by default instead of duplicating them in every module.

For components/modules there probably comes a time where it's worth enabling helpers - e.g. here's the PR for enabling them in React Bootstrap: react-bootstrap/react-bootstrap#841

You also need to add babel-runtime as a dependency when enabling external helpers, so this should be added to the questions which get asked when creating a component project.

@insin
Copy link
Owner Author

insin commented Jun 1, 2017

Looks like this should wait until Babel 7: babel/babel#5442

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant