Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m_remove has wrong syntax for /remove command #860

Closed
HelixSpiral opened this issue May 26, 2014 · 1 comment
Closed

m_remove has wrong syntax for /remove command #860

HelixSpiral opened this issue May 26, 2014 · 1 comment
Labels
enhancement New feature or request
Milestone

Comments

@HelixSpiral
Copy link
Contributor

When it was written whoever wrote it did the channel/nick parameters wrong, since then a second command fpart has been added with the correct syntax.

However, for clients that are implementing /remove this breaks on any inspircd network due to it being wrong.

I think the syntax for /remove should be fixed to work the correct way. The amount of disruption caused by this should not be overly huge.

Example of a client that's not going to work with inspircds implementation: weechat/weechat#91
Exact line: weechat/weechat@34098ce#diff-dacbf32b195ec9426d1d0bae88776811R4093

@attilamolnar attilamolnar added bug and removed minor labels May 26, 2014
@attilamolnar attilamolnar added this to the v2.2 milestone May 26, 2014
attilamolnar added a commit that referenced this issue Jun 25, 2014
The old syntax is now deprecated

Fixes issue #860 reported by @shawn-smith
@attilamolnar
Copy link
Member

Fixed, we can remove /FPART or turn it into an alias after 2.2 when 2.0 compatibility is dropped.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants