Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Generalise Evaluator Fn #1001

Closed
EdanToledo opened this issue Feb 5, 2024 · 0 comments · Fixed by #1084
Closed

[FEATURE] Generalise Evaluator Fn #1001

EdanToledo opened this issue Feb 5, 2024 · 0 comments · Fixed by #1084
Labels
enhancement New feature or request

Comments

@EdanToledo
Copy link
Contributor

Please describe the purpose of the feature. Is it related to a problem?

It would be very nice if the evaluator function was generic enough for future algorithms. It can be frustrating that a highly specific form is required. i.e. currently the network apply is force vmapped and it uses the default call function. Complex algorithms have complex networks and multiple different call functions and might not be suitable for this paradigm.

Describe the solution you'd like

An easy way to do this would be that a user passes in an "actor_fn" which has a specific input and output api. A user would create this and perhaps make a partial fn to fit the correct api. This could be suitable for feedforward and recurrent networks as long as the API is adhered to. I feel that although this is adding structure that could make a user confused, its a simple enough request that it wouldn't require the user to dig deep at all and would benefit creating new algorithms.

@EdanToledo EdanToledo added the enhancement New feature or request label Feb 5, 2024
@sash-a sash-a linked a pull request Jul 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant