Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTPS client tracing #33

Closed
schmod opened this issue Jan 25, 2018 · 5 comments · Fixed by #74
Closed

HTTPS client tracing #33

schmod opened this issue Jan 25, 2018 · 5 comments · Fixed by #74

Comments

@schmod
Copy link
Contributor

schmod commented Jan 25, 2018

Is there support for tracing outgoing HTTPS requests on the roadmap?
@bripkens
Copy link
Contributor

Are you referring to execution of HTTP requests via the https module? So that would be require('https').request(…)? I think this was just an oversight possibly based on the assumption that https.request just delegates to http.request (which it doesn't in Node.js/master).

Implementation for this will most likely be simple, but I don't have time to take care of the tests right now. I can try to take a look at it late next week.

@schmod
Copy link
Contributor Author

schmod commented Jan 26, 2018 •
edited

Yep. AFAIK, 'http' and 'https' are maintained as completely separate implementations in Node. Thanks for offering to take a look!

@pglombardo
Copy link

This was added and released in 1.30.2: https://github.com/instana/nodejs-sensor/blob/master/CHANGELOG.md#1302

@schmod
Copy link
Contributor Author

schmod commented Apr 12, 2018

The change in 1.30.2 was for HTTP servers; not clients.

@pglombardo
Copy link

Doh you're right. Thanks for pointing out. I glanced too quickly at this.

@pglombardo pglombardo reopened this Apr 13, 2018
basti1302 added a commit that referenced this issue Jul 19, 2018
@basti1302
feat(tracing): Instrument https client
63f3100 
fixes #33
@basti1302 basti1302 mentioned this issue Jul 19, 2018
Merged
basti1302 added a commit that referenced this issue Jul 19, 2018
@basti1302
feat(tracing): Instrument https client
3107410 
fixes #33
basti1302 added a commit that referenced this issue Jul 19, 2018
@basti1302
feat(tracing): Instrument https client
ef0f7df 
fixes #33
basti1302 added a commit that referenced this issue Jul 19, 2018
@basti1302
feat(tracing): Instrument https client
b85ae6f 
fixes #33

Also, omit lint step when running tests from dev script

The use case for bin/run-tests.sh is (among others) to run the tests
continuously while working on an instrumentation. Having the test run
fail with a linting problem is distracting, so a new npm run script
test:nolint has been introduced to be able to run tests without linting.

Note that npm test of course still runs eslint.

* feat(tracing): Instrument https client
basti1302 added a commit that referenced this issue Jul 19, 2018
@basti1302
feat(tracing): Instrument https client
8650345 
fixes #33

Also, omit lint step when running tests from dev script.

The use case for bin/run-tests.sh is (among others) to run the tests
continuously while working on an instrumentation. Having the test run
fail with a linting problem is distracting, so a new npm run script
test:nolint has been introduced to be able to run tests without linting.

Note that npm test of course still runs eslint.
willianpc added a commit that referenced this issue Apr 6, 2021
@willianpc
# This is a combination of 56 commits.
2768bb6 
# This is the 1st commit message:

Added basic test apps

# This is the commit message #2:

improved test app a little bit

# This is the commit message #3:

more refactoring; wip: process, concurrency named process in test app

# This is the commit message #4:

added consumer as process

# This is the commit message #5:

wip: in the middle of another refactoring

# This is the commit message #6:

test app covers all 12 cases

# This is the commit message #7:

started instrumentation

# This is the commit message #8:

wip: instrumenting add() function

# This is the commit message #9:

wip: dealing with repeatable jobs

# This is the commit message #10:

Using repeat with limit. avoid using cron

# This is the commit message #11:

added bulk job sending

# This is the commit message #12:

small refactoring in sender test app

# This is the commit message #13:

exit span instrumented for single and repeatable jobs

# This is the commit message #14:

wip: bulk immediate jobs

[skip ci]

# This is the commit message #15:

wip: testing the instrumentation of bulk > send job

[skip ci]

# This is the commit message #16:

complete instrumentation of exit spans

# This is the commit message #17:

docs(changelog): prepare release 1.117.0

[skip ci]

# This is the commit message #18:

v1.117.0

# This is the commit message #19:

fix: bypass native addon loading in worker threads

Co-authored-by: Willian Carvalho <willian.carvalho@instana.com>
# This is the commit message #20:

docs(changelog): prepare release 1.117.1

[skip ci]

# This is the commit message #21:

v1.117.1

# This is the commit message #22:

test(tracing): make batching test less flaky

# This is the commit message #23:

chore: add script for splitting CI output according to package

[skip ci]

# This is the commit message #24:

fix: update to shimmer@1.2.1 to be able to patch async functions

Specifically, that version includes this fix:
othiym23/shimmer@ec15ba2

# This is the commit message #25:

test(tracing): fix path for custom tags

# This is the commit message #26:

wip: added ENTRY span instrumentation

# This is the commit message #27:

renamed child process.js; removed extra execTime param from /POST; added client HTTP call

# This is the commit message #28:

immediate and repeatable jobs instrumented correctly

[skip ci]

# This is the commit message #29:

small refactoring/cleanup; [skip ci]

# This is the commit message #30:

introduced tests

[skip ci]

# This is the commit message #31:

Included test for Callback x Bulk [skip ci]

# This is the commit message #32:

wip: attempting to instrument master.js [skip ci]

# This is the commit message #33:

instrument child process with an extra entry span

# This is the commit message #34:

experimental: activate tracing immediately, without waiting for connection to agent

# This is the commit message #35:

send spans directly from Bull child process workers and wait for them to be offloaded

# This is the commit message #36:

fix linting issues

# This is the commit message #37:

Updating agent uuid from env var info

[skip ci]

# This is the commit message #38:

fixed PID casting to string [skip ci]

# This is the commit message #39:

no more IPC, write to a file instead

# This is the commit message #40:

attach trace context to each individual IPC message instead of env var at process start

# This is the commit message #41:

avoid duplicated bull entry span

# This is the commit message #42:

fixed naming convention; replaced fs/promises by fs; guarantee that opts object exists

# This is the commit message #43:

added disabled trace tests

# This is the commit message #44:

lift the requirement for applying span.disableAutoEnd/span.end()

# This is the commit message #45:

Running tests for trace disabled and suppressed

# This is the commit message #46:

all instana data is removed before customer gets the processed job data

# This is the commit message #47:

Added test to make sure no Instana data is left in Job data

# This is the commit message #48:

Added withError cases

# This is the commit message #49:

Skipping tests for Node version < 10

# This is the commit message #50:

fix(opentracing): default to type entry when no parent is referenced

# This is the commit message #51:

docs(changelog): prepare release 1.117.2

[skip ci]

# This is the commit message #52:

v1.117.2

# This is the commit message #53:

fix(metrics): register gc stats loader listener immediately

This fixes an issue where GC metrics would not be available when the
dependency gcstats.js was already present in node_modules and the
activation of the gc metrics module would happen too late.

# This is the commit message #54:

docs(changelog): prepare release 1.117.3

[skip ci]

# This is the commit message #55:

v1.117.3

# This is the commit message #56:

docs(contributing): document the need to install PostgreSQL headers

(Only required for local development.)

Plus: Additional info about rate limited OTP when publishing.

[skip ci]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(tracing): Instrument https client instana/nodejs
3 participants
@pglombardo @bripkens @schmod