feat: added support for tedious v16 and v17 #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
changed the title
kirrg001
force-pushed
the
investigate-otel-tedious-instru
branch
from
5bb8d65
to
785760f
Compare
|
Draft PR still. Our tedious app test loads a wrong tedious dependency from mssql v9 (tedious v15) |
|
Trying to switch to yarn to get rid of the annoying installation problems with npm. |
I will do that after the merge, because we need to ship this update. |
- typeorm needed a refresh, because it relied on mssql v9, which installs tedious v15 - we thought we have tested against v17, but we didn't
kirrg001
force-pushed
the
investigate-otel-tedious-instru
branch
from
179f33d
to
788e90d
Compare
kirrg001
commented
Jun 17, 2024
| @@ -94,6 +94,7 @@ | |||
| "@grpc/proto-loader": "^0.7.13", | |||
| "@hapi/hapi": "^21.3.10", | |||
| "@ibm/tekton-lint": "^1.0.0-beta.9", | |||
| "@opentelemetry/instrumentation": "0.50.0", | |||
There was a problem hiding this comment.
This is a workaround for now.
Hopefully we can move to yarn asap.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-1561
An underlying npm workspaces bug made us believe that we are testing against tedious v17.
See comment.