Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Controlled menu does not animate during closing #25

Closed
sodik82 opened this issue Mar 14, 2017 · 3 comments
Closed

Controlled menu does not animate during closing #25

sodik82 opened this issue Mar 14, 2017 · 3 comments

Comments

@sodik82
Copy link
Contributor

sodik82 commented Mar 14, 2017

It seems that controlled menu does not animate when closed via props.

Expected: it should animate same as uncontrolled menu.

version: 0.7.2
platforms: both
@robertxsonny
Copy link

@sodik82 I solve this issue by putting close menu action (i.e. setting local state to false) in timeout (around 200ms).

Probably this logic could be added to the menu component as well?

@sodik82
Copy link
Contributor Author

sodik82 commented Apr 1, 2017

thanks for workaround - right now I still believe it can be fixed properly :) but I need to look little bit deeper.

@sodik82
Copy link
Contributor Author

sodik82 commented May 12, 2017

should be fixed in 0.7.4

@sodik82 sodik82 closed this as completed May 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sodik82 @robertxsonny