Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve flexibility for defining sample's concentrations #1753

Closed
diegoliberman opened this issue Aug 12, 2022 — with Manas.Tech Commit · 2 comments · Fixed by #1787
Closed

Improve flexibility for defining sample's concentrations #1753

diegoliberman opened this issue Aug 12, 2022 — with Manas.Tech Commit · 2 comments · Fixed by #1787
Assignees

Comments

Copy link
Contributor

diegoliberman commented Aug 12, 2022

  1. In the sample detail, the field for entering the concentration should be just an input box expressing the unit copies/µl. The user may enter absolute numbers such as 600 or scientific notation such as 75e+6.
    1. When creating a sample, the user may enter any of those 2 formats.
    2. When editing a sample, the system will show the absolute number if it's less than 5 figures. Else the scientific notation will be used.
  2. Concentrations that were saved before these changes: we need to delete the concentration value and exponent, and make sure we store the corresponding absolute number that can be used for correctly displaying as mentioned in item 1.2.
  3. Creating boxes should honor the new way of storing concentrations. Even when we're planning to implement V2 of boxes, let's please implement the concentration changes and adapt other features if necessary. The effort will be harvested in V2.
  4. The concentration is included when downloading the inventory of a box. Make sure we're populating this column with the absolute value of the concentration.
  5. The concentration is one of the blinded fields. Make sure the blinding feature is still working as expected in regards to the blinding and unblinding of the concentration.

Acceptance criteria

  1. I can enter a concentration in the sample detail as 500 and 75e+6 (scientific notation).
  2. I open a sample with a concentration greater than 99,999 and the absolute number is shown.
  3. I open a sample with a concentration lower than 100,000 and it's shown in the scientific notation.
  4. I create an LOD box and the concentrations are shown (within the sample detail) as described in 3 and 4.
  5. Same as 5 for Variants.
  6. Same as 5 for Challenge.
  7. I can download the inventory of a box and the Concentration column is populated with the absolute number.
  8. If I blind a box, and transfer it the recipient can't see the concentration the sample detail and in the inventory.
  9. If I don't blind a box and transfer it, the recipient sees the concentration in the sample detail and in the inventory.
@ysbaddaden
Copy link
Contributor

What about decimals, and numbers below 1? For example 1e-23 or 0.1 or even weirder 0.012e-3?

@leandroradusky leandroradusky self-assigned this Nov 7, 2022
@leandroradusky
Copy link
Contributor

leandroradusky commented Nov 8, 2022

What about decimals

Given that the units are copies/ml (not ul cc @diegoliberman) the units will be integer numbers, the only thing is that they could be entered in scientific notation. We're measuring here copies of the virus per milliliter of the sample, you will have only integers (maybe long integers) since you don't put fractions of copies of the viruses.

If the entered number is a decimal, IMO we should just take the integer part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants