Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert changes to printing box labels for both sender/recipient #1766

Closed
diegoliberman opened this issue Oct 24, 2022 — with Manas.Tech Commit · 1 comment · Fixed by #1779
Closed

Revert changes to printing box labels for both sender/recipient #1766

diegoliberman opened this issue Oct 24, 2022 — with Manas.Tech Commit · 1 comment · Fixed by #1779
Assignees
@leandroradusky
Labels
development

Comments

@diegoliberman Manas.Tech Commit
Copy link
Contributor

diegoliberman commented Oct 24, 2022 •
edited by ysbaddaden
Loading

We want to revert feature #1725 and #1747 merged as #1746. It was never released and is only available in main.

Unlike stated in #1755 we shouldn't have to restore anything, other features are isolated to their own commits. We only need to revert commit 98bafc0 (we don't reset back to that commit). But it doesn't hurt to check!
@diegoliberman diegoliberman mentioned this issue Oct 24, 2022
Closed
@ysbaddaden ysbaddaden changed the title Revert commits Remove changes to printing box labels for both sender/recipient Oct 27, 2022
@ysbaddaden ysbaddaden changed the title Remove changes to printing box labels for both sender/recipient Revert changes to printing box labels for both sender/recipient Oct 27, 2022
@leandroradusky leandroradusky self-assigned this Nov 2, 2022
@ysbaddaden ysbaddaden linked a pull request Nov 7, 2022 that will close this issue
Simplify boxes transfer blinding flow - Stage 1 #1779
Merged
@diegoliberman
Copy link
Contributor Author

Testing instructions: see #1755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@leandroradusky leandroradusky

Labels
development
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Simplify boxes transfer blinding flow - Stage 1 instedd/cdx
3 participants
@ysbaddaden @leandroradusky @diegoliberman