Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the blind check box to the box detail #1769

Closed
diegoliberman opened this issue Oct 24, 2022 — with Manas.Tech Commit · 4 comments · Fixed by #1780
Closed

Move the blind check box to the box detail #1769

diegoliberman opened this issue Oct 24, 2022 — with Manas.Tech Commit · 4 comments · Fixed by #1780
Assignees

Comments

Copy link
Contributor

No description provided.

@leandroradusky leandroradusky self-assigned this Nov 4, 2022
@leandroradusky
Copy link
Contributor

I've moved the checkbox to the box detail and samples blind correctly.
But from the index we can access box detail ("read only"), there is no edit there to allow unblinding the samples and this is only available after transferring it. Is this an expected behavior? or we should as well allow unblinding samples from the box details form?
cc @diegoliberman

@diegoliberman
Copy link
Contributor Author

We will allow to edit in #1772, but it isn't a priority right now. Unless you think it's easy (<8h) and prefer to do it now.

@ysbaddaden
Copy link
Contributor

This change means that: the sender no longer blinds all boxes when creating a transfer package, but selectively chooses to blind some boxes when she creates them. Is that the correct behavior?

For the create box part, there should be no issue with permissions: the creator of the box is the owner of the box.

@diegoliberman
Copy link
Contributor Author

This is correct. In fact, transferring multiple boxes at once, isn't a known use case. Adding more than 1 box in the transfer was implemented because it added a feature and it was trivial at the time. If it ever becomes a difficulty, we'll change it so that only 1 box can be transferred at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants