Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate samples when creating boxes #1877

Closed
ysbaddaden opened this issue Jan 27, 2023 · 2 comments · Fixed by #1894 or #1898
Closed

Validate samples when creating boxes #1877

ysbaddaden opened this issue Jan 27, 2023 · 2 comments · Fixed by #1894 or #1898
Assignees

Comments

@ysbaddaden
Copy link
Contributor

ysbaddaden commented Jan 27, 2023

When creating a box from selected samples, we should still do some validation based on the purpose:

  1. Variant boxes created from samples should contain samples coming at least from 2 different batches;
  2. Challenge boxes created from samples should at least contain one distractor and one non-distractor sample.
  3. LOD and Other boxes created from samples don't need to more validation.

Follow up to #1867

@sardar-usman
Copy link

@leandroradusky The error message should be different as we have to add 2 different batches for Variant.
Screenshot 2023-02-06 at 9 11 06 PM

@sardar-usman
Copy link

@leandroradusky It is working fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants