Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload results informing wrong not-found-uuid count if repeated samples in csv file #1891

Closed
sardar-usman opened this issue Feb 2, 2023 — with Manas.Tech Commit · 3 comments · Fixed by #1895
Closed
Assignees
Labels

Comments

Copy link

sardar-usman commented Feb 2, 2023

Steps that you should follow in order to see the bug, ie.

  1. Go to 'Samples' page.
  2. Click on Upload Results button.
  3. On Upload Results page click on "Add File" button.
  4. Upload the CSV file of created samples with duplicate UUID's from the system.
  5. Click on "Upload Result" button.
  6. It's showing wrong informing count.

Expected

It should show the correct informing wrong not-found-uuid count.
Screenshot 2023-02-02 at 4 48 14 PM

My setup

  • Device: Laptop
  • OS: macOS
  • Browser: Chrome
@leandroradusky leandroradusky self-assigned this Feb 2, 2023
@leandroradusky
Copy link
Contributor

I've worked on this... the problem is with duplicated UUIDs within the same file.
My proposed solution: if there are invalid or duplicated sample uuids, show this modal:

image

And then, inform invalid uuids (non existent within CDx), just as before:

image

But for valid duplicated samples just ignore the second appearance, as in this file that contains twice the same sample:

image

I propose this since, as you can see on the second image, to make a warning message x sample uuids not found, y sample uuids duplicated seems a quite long message.

Thoughts @diegoliberman?

@diegoliberman
Copy link
Contributor

@leandroradusky I would have suggested exactly the same. Go for it.

@diegoliberman diegoliberman changed the title "Upload results informing wrong not-found-uuid count if repeated samples in csv file" Upload results informing wrong not-found-uuid count if repeated samples in csv file Feb 6, 2023
@sardar-usman
Copy link
Author

@leandroradusky it is working as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants