Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can create box without selecting to create or select samples #1913

Closed
ysbaddaden opened this issue Feb 9, 2023 · 1 comment · Fixed by #1914
Closed

Can create box without selecting to create or select samples #1913

ysbaddaden opened this issue Feb 9, 2023 · 1 comment · Fixed by #1914
Assignees
Labels

Comments

@ysbaddaden
Copy link
Contributor

Try to create a box, select a purpose but don't select an option to create new samples or select existing sample and submit the form. The box will be created and won't show up in the list of boxes yet be counted (triggering bug #1858).

We must validate than a valid option (add_batches or add_samples) was selected in BoxForm.

@sardar-usman
Copy link

@ysbaddaden It's not allowing to create Box without any (add_batches or add_samples). Working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants