Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(model): Refactoring AI Tasks for Consistency Across Text and Image Generation #461

Merged
merged 4 commits into from
Dec 6, 2023

Conversation

tonywang10101
Copy link
Contributor

This commit introduces a refactoring of several AI tasks to ensure consistency and clarity across our text and image generation functionalities. Our main focus is to address the inconsistencies previously observed in how certain tasks were categorized.

Changes include:

  • Separating 'text generate chat', 'text generate', and 'visual question answering' under the umbrella of text generation tasks.
  • Reorganizing 'text2image' and 'image2image' tasks into a more coherent image generation category.

This restructuring is in alignment with the Linear ticket INS-2574, ensuring a more streamlined and intuitive categorization of AI tasks. This update makes it easier for users and developers to navigate and understand our AI task offerings, enhancing the overall user experience.

Copy link

linear bot commented Dec 3, 2023

@tonywang10101
Copy link
Contributor Author

Before merging this PR, we should merge and update protobufs PR first.

Besides, I'll update DVC package version in this release.

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 495 lines in your changes are missing coverage. Please review.

Comparison is base (47e6e31) 1.01% compared to head (ca85d21) 0.94%.

Files Patch % Lines
pkg/handler/payload.go 0.00% 346 Missing ⚠️
pkg/handler/public_handler.go 0.00% 146 Missing ⚠️
pkg/service/service.go 0.00% 2 Missing ⚠️
pkg/utils/utils.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #461      +/-   ##
========================================
- Coverage   1.01%   0.94%   -0.08%     
========================================
  Files         10      10              
  Lines       5589    6027     +438     
========================================
  Hits          57      57              
- Misses      5524    5962     +438     
  Partials       8       8              
Flag Coverage Δ
unittests 0.94% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heiruwu
Copy link
Member

heiruwu commented Dec 4, 2023

also you might want to take a look at the CodeQL scanning result, not sure if it will be a problem

Copy link
Member

@heiruwu heiruwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heiruwu heiruwu merged commit e827130 into main Dec 6, 2023
10 of 11 checks passed
@heiruwu heiruwu deleted the INS-2574 branch December 6, 2023 09:03
heiruwu pushed a commit that referenced this pull request Dec 15, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.21.0-alpha](v0.20.0-alpha...v0.21.0-alpha)
(2023-12-14)


### Features

* **model:** refactoring AI Tasks for Consistency Across Text and Image
Generation
([#461](#461))
([e827130](e827130))
* **redis:** use redis for model state caching
([#472](#472))
([3b6b977](3b6b977))


### Bug Fixes

* **model:** fix grpc message size limit issue
([#474](#474))
([1ec7ae1](1ec7ae1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants