Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redis): use redis for model state caching #472

Merged
merged 2 commits into from
Dec 13, 2023
Merged

feat(redis): use redis for model state caching #472

merged 2 commits into from
Dec 13, 2023

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Dec 13, 2023

Because

  • json file as model cache state introduces race condition when multiple models are deploying

This commit

  • use redis to cache model files state

fixes ins-2909

Copy link

linear bot commented Dec 13, 2023

@heiruwu heiruwu changed the title feat(cache): use redis for model state caching feat(redis): use redis for model state caching Dec 13, 2023
Copy link

linear bot commented Dec 13, 2023

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (c07bc07) 0.94% compared to head (6049a75) 0.94%.

Files Patch % Lines
pkg/utils/utils.go 0.00% 19 Missing ⚠️
pkg/handler/public_handler.go 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #472   +/-   ##
=====================================
  Coverage   0.94%   0.94%           
=====================================
  Files         10      10           
  Lines       6047    6016   -31     
=====================================
  Hits          57      57           
+ Misses      5982    5951   -31     
  Partials       8       8           
Flag Coverage Δ
unittests 0.94% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@heiruwu heiruwu merged commit 69fb9e8 into main Dec 13, 2023
11 checks passed
@heiruwu heiruwu deleted the INS-2908 branch December 13, 2023 08:27
heiruwu added a commit that referenced this pull request Dec 13, 2023
Because

- json file as model cache state introduces race condition when multiple
models are deploying

This commit

- use redis to cache model files state

fixes ins-2909
heiruwu pushed a commit that referenced this pull request Dec 15, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.21.0-alpha](v0.20.0-alpha...v0.21.0-alpha)
(2023-12-14)


### Features

* **model:** refactoring AI Tasks for Consistency Across Text and Image
Generation
([#461](#461))
([e827130](e827130))
* **redis:** use redis for model state caching
([#472](#472))
([3b6b977](3b6b977))


### Bug Fixes

* **model:** fix grpc message size limit issue
([#474](#474))
([1ec7ae1](1ec7ae1))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants