Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd,pkg): refactor codebase to align with golanci-linter checks #506

Merged
merged 3 commits into from
Feb 5, 2024
Merged

fix(cmd,pkg): refactor codebase to align with golanci-linter checks #506

merged 3 commits into from
Feb 5, 2024

Conversation

heiruwu
Copy link
Member

@heiruwu heiruwu commented Feb 5, 2024

Because

  • current codebase is not following some golang best practices

This commit

  • refactor codebase to be more aligned with go philosophy and provides easier readability and maintainability

resolves INS-3601

@linear Linear
Copy link

linear bot commented Feb 5, 2024

INS-3601 fix golanci-lint errors

@heiruwu heiruwu merged commit b213812 into main Feb 5, 2024
11 of 12 checks passed
@heiruwu heiruwu deleted the fix-styling branch February 5, 2024 13:08
@droplet-bot droplet-bot mentioned this pull request Feb 5, 2024
Merged
heiruwu pushed a commit that referenced this pull request Feb 16, 2024
@droplet-bot
chore(main): release 0.22.0-alpha (#505)
eb92292 
🤖 I have created a release *beep* *boop*
---


##
[0.22.0-alpha](v0.21.3-alpha...v0.22.0-alpha)
(2024-02-16)


### ⚠ BREAKING CHANGES

* **triton:** deprecate triton inference server
([#512](#512))

### Features

* **acl,org:** adopt ACL and add organization endpoints
([#504](#504))
([13a1650](13a1650))


### Bug Fixes

* **cmd,pkg:** refactor codebase to align with `golanci-linter` checks
([#506](#506))
([b213812](b213812))
* **handler:** fix multipart request
([352a4ae](352a4ae))
* **pkg:** fix isError and set maxBatchSize to 0
([2adfe5b](2adfe5b))
* **pkg:** fix org model namespace
([#510](#510))
([f4be09c](f4be09c))
* **service:** fix workflow retry when deleting
([adcbde5](adcbde5))
* **service:** remove org subscription check
([76cd66f](76cd66f))
* **worker:** fix temporal cloud namespace init
([#513](#513))
([17c5d68](17c5d68))


### Code Refactoring

* **triton:** deprecate triton inference server
([#512](#512))
([f8a277d](f8a277d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@droplet-bot droplet-bot mentioned this pull request Feb 16, 2024
Merged
heiruwu pushed a commit that referenced this pull request Feb 16, 2024
@droplet-bot
chore(main): release 0.22.0-alpha (#516)
84f756a 
🤖 I have created a release *beep* *boop*
---


##
[0.22.0-alpha](v0.21.3-alpha...v0.22.0-alpha)
(2024-02-16)


### ⚠ BREAKING CHANGES

* **triton:** deprecate triton inference server
([#512](#512))

### Features

* **acl,org:** adopt ACL and add organization endpoints
([#504](#504))
([13a1650](13a1650))


### Bug Fixes

* **cmd,pkg:** refactor codebase to align with `golanci-linter` checks
([#506](#506))
([b213812](b213812))
* **handler:** fix multipart request
([352a4ae](352a4ae))
* **pkg:** fix isError and set maxBatchSize to 0
([2adfe5b](2adfe5b))
* **pkg:** fix org model namespace
([#510](#510))
([f4be09c](f4be09c))
* **service:** fix workflow retry when deleting
([adcbde5](adcbde5))
* **service:** remove org subscription check
([76cd66f](76cd66f))
* **worker:** fix temporal cloud namespace init
([#513](#513))
([17c5d68](17c5d68))


### Code Refactoring

* **triton:** deprecate triton inference server
([#512](#512))
([f8a277d](f8a277d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@droplet-bot droplet-bot mentioned this pull request Feb 20, 2024
Merged
heiruwu pushed a commit that referenced this pull request Feb 20, 2024
@droplet-bot
chore(main): release 0.22.0-alpha (#517)
e784455 
🤖 I have created a release *beep* *boop*
---


##
[0.22.0-alpha](v0.21.3-alpha...v0.22.0-alpha)
(2024-02-20)


### ⚠ BREAKING CHANGES

* **triton:** deprecate triton inference server
([#512](#512))

### Features

* **acl,org:** adopt ACL and add organization endpoints
([#504](#504))
([13a1650](13a1650))


### Bug Fixes

* **cmd,pkg:** refactor codebase to align with `golanci-linter` checks
([#506](#506))
([b213812](b213812))
* **handler:** fix multipart request
([352a4ae](352a4ae))
* **pkg:** fix isError and set maxBatchSize to 0
([2adfe5b](2adfe5b))
* **pkg:** fix org model namespace
([#510](#510))
([f4be09c](f4be09c))
* **service:** fix workflow retry when deleting
([adcbde5](adcbde5))
* **service:** remove org subscription check
([76cd66f](76cd66f))
* **worker:** fix temporal cloud namespace init
([#513](#513))
([17c5d68](17c5d68))


### Code Refactoring

* **triton:** deprecate triton inference server
([#512](#512))
([f8a277d](f8a277d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@droplet-bot droplet-bot mentioned this pull request Feb 20, 2024
Merged
heiruwu pushed a commit that referenced this pull request Feb 20, 2024
@droplet-bot
chore(main): release 0.22.0-alpha (#518)
4e9cc02 
🤖 I have created a release *beep* *boop*
---


##
[0.22.0-alpha](v0.21.3-alpha...v0.22.0-alpha)
(2024-02-20)


### ⚠ BREAKING CHANGES

* **triton:** deprecate triton inference server
([#512](#512))

### Features

* **acl,org:** adopt ACL and add organization endpoints
([#504](#504))
([13a1650](13a1650))


### Bug Fixes

* **cmd,pkg:** refactor codebase to align with `golanci-linter` checks
([#506](#506))
([b213812](b213812))
* **handler:** fix multipart request
([352a4ae](352a4ae))
* **pkg:** fix isError and set maxBatchSize to 0
([2adfe5b](2adfe5b))
* **pkg:** fix org model namespace
([#510](#510))
([f4be09c](f4be09c))
* **service:** fix workflow retry when deleting
([adcbde5](adcbde5))
* **service:** remove org subscription check
([76cd66f](76cd66f))
* **worker:** fix temporal cloud namespace init
([#513](#513))
([17c5d68](17c5d68))


### Code Refactoring

* **triton:** deprecate triton inference server
([#512](#512))
([f8a277d](f8a277d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@droplet-bot droplet-bot mentioned this pull request Feb 20, 2024
Merged
heiruwu pushed a commit that referenced this pull request Feb 20, 2024
@droplet-bot
chore(main): release 0.22.0-alpha (#519)
a1dbb67 
🤖 I have created a release *beep* *boop*
---


##
[0.22.0-alpha](v0.21.3-alpha...v0.22.0-alpha)
(2024-02-20)


### ⚠ BREAKING CHANGES

* **triton:** deprecate triton inference server
([#512](#512))

### Features

* **acl,org:** adopt ACL and add organization endpoints
([#504](#504))
([13a1650](13a1650))


### Bug Fixes

* **cmd,pkg:** refactor codebase to align with `golanci-linter` checks
([#506](#506))
([b213812](b213812))
* **handler:** fix multipart request
([352a4ae](352a4ae))
* **pkg:** fix isError and set maxBatchSize to 0
([2adfe5b](2adfe5b))
* **pkg:** fix org model namespace
([#510](#510))
([f4be09c](f4be09c))
* **service:** fix workflow retry when deleting
([adcbde5](adcbde5))
* **service:** remove org subscription check
([76cd66f](76cd66f))
* **usage:** update usage client init
([1c9b35b](1c9b35b))
* **worker:** fix temporal cloud namespace init
([#513](#513))
([17c5d68](17c5d68))


### Code Refactoring

* **triton:** deprecate triton inference server
([#512](#512))
([f8a277d](f8a277d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@droplet-bot droplet-bot mentioned this pull request Feb 20, 2024
Merged
heiruwu pushed a commit that referenced this pull request Feb 20, 2024
@droplet-bot
chore(main): release 0.22.0-alpha (#520)
4830db8 
🤖 I have created a release *beep* *boop*
---


##
[0.22.0-alpha](v0.21.3-alpha...v0.22.0-alpha)
(2024-02-20)


### ⚠ BREAKING CHANGES

* **triton:** deprecate triton inference server
([#512](#512))

### Features

* **acl,org:** adopt ACL and add organization endpoints
([#504](#504))
([13a1650](13a1650))


### Bug Fixes

* **cmd,pkg:** refactor codebase to align with `golanci-linter` checks
([#506](#506))
([b213812](b213812))
* **handler:** fix multipart request
([352a4ae](352a4ae))
* **pkg:** fix isError and set maxBatchSize to 0
([2adfe5b](2adfe5b))
* **pkg:** fix org model namespace
([#510](#510))
([f4be09c](f4be09c))
* **service:** fix workflow retry when deleting
([adcbde5](adcbde5))
* **service:** remove org subscription check
([76cd66f](76cd66f))
* **usage:** update usage client init
([92d24b5](92d24b5))
* **worker:** fix temporal cloud namespace init
([#513](#513))
([17c5d68](17c5d68))


### Code Refactoring

* **triton:** deprecate triton inference server
([#512](#512))
([f8a277d](f8a277d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@droplet-bot droplet-bot mentioned this pull request Feb 20, 2024
Merged
heiruwu pushed a commit that referenced this pull request Feb 20, 2024
@droplet-bot
chore(main): release 0.22.0-alpha (#521)
08c7bf6 
🤖 I have created a release *beep* *boop*
---


##
[0.22.0-alpha](v0.21.3-alpha...v0.22.0-alpha)
(2024-02-20)


### ⚠ BREAKING CHANGES

* **triton:** deprecate triton inference server
([#512](#512))

### Features

* **acl,org:** adopt ACL and add organization endpoints
([#504](#504))
([13a1650](13a1650))


### Bug Fixes

* **cmd,pkg:** refactor codebase to align with `golanci-linter` checks
([#506](#506))
([b213812](b213812))
* **handler:** fix multipart request
([352a4ae](352a4ae))
* **pkg:** fix isError and set maxBatchSize to 0
([2adfe5b](2adfe5b))
* **pkg:** fix org model namespace
([#510](#510))
([f4be09c](f4be09c))
* **service:** fix workflow retry when deleting
([adcbde5](adcbde5))
* **service:** remove org subscription check
([76cd66f](76cd66f))
* **usage:** add missing org usage collection
([56b27f2](56b27f2))
* **worker:** fix temporal cloud namespace init
([#513](#513))
([17c5d68](17c5d68))


### Code Refactoring

* **triton:** deprecate triton inference server
([#512](#512))
([f8a277d](f8a277d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
@droplet-bot droplet-bot mentioned this pull request Feb 20, 2024
Merged
heiruwu pushed a commit that referenced this pull request Feb 20, 2024
@droplet-bot
chore(main): release 0.22.0-alpha (#522)
20c6127 
🤖 I have created a release *beep* *boop*
---


##
[0.22.0-alpha](v0.21.3-alpha...v0.22.0-alpha)
(2024-02-20)


### ⚠ BREAKING CHANGES

* **triton:** deprecate triton inference server
([#512](#512))

### Features

* **acl,org:** adopt ACL and add organization endpoints
([#504](#504))
([13a1650](13a1650))


### Bug Fixes

* **cmd,pkg:** refactor codebase to align with `golanci-linter` checks
([#506](#506))
([b213812](b213812))
* **handler:** fix multipart request
([352a4ae](352a4ae))
* **pkg:** fix isError and set maxBatchSize to 0
([2adfe5b](2adfe5b))
* **pkg:** fix org model namespace
([#510](#510))
([f4be09c](f4be09c))
* **service:** fix workflow retry when deleting
([adcbde5](adcbde5))
* **service:** remove org subscription check
([76cd66f](76cd66f))
* **usage:** add missing org usage collection
([239d3f4](239d3f4))
* **worker:** fix temporal cloud namespace init
([#513](#513))
([17c5d68](17c5d68))


### Code Refactoring

* **triton:** deprecate triton inference server
([#512](#512))
([f8a277d](f8a277d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

@xiaofei-du xiaofei-du Awaiting requested review from xiaofei-du xiaofei-du is a code owner

Assignees
No one assigned
Labels
instill model
Projects
No open projects
🔮 Instill Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@heiruwu @droplet-bot