Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: create TriggerPipeline rpc for new model-backend #27

Merged
merged 1 commit into from
Feb 24, 2022
Merged

fix: create TriggerPipeline rpc for new model-backend #27

merged 1 commit into from
Feb 24, 2022

Conversation

bochengyang
Copy link
Contributor

Because

  • new model-backend supports URL/base64 inference endpoint, so pipeline-backend can also have the trigger endpoint to trigger pipeline and send URL/base64 to model-backend
  • separate image and URL/base64 trigger request

This commit

  • create TriggerPipeline rpc for new model-backend

xiaofei-du
xiaofei-du approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@xiaofei-du xiaofei-du left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@bochengyang bochengyang merged commit 3c9f861 into main Feb 24, 2022
@bochengyang bochengyang deleted the add-pipeline-rpc-and-message branch February 24, 2022 13:55
@droplet-bot droplet-bot mentioned this pull request Feb 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiaofei-du xiaofei-du xiaofei-du approved these changes

@Phelan164 Phelan164 Awaiting requested review from Phelan164

@pinglin pinglin Awaiting requested review from pinglin pinglin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
No open projects
🔮 Instill Core
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bochengyang @xiaofei-du