Skip to content

Commit

Permalink
Add helpful gergich suggestion about ERB warning
Browse files Browse the repository at this point in the history
Change-Id: Id158bac164b3fdb989ed27faef085f4600ccabf6
Reviewed-on: https://gerrit.instructure.com/88425
Reviewed-by: Landon Wilkins <lwilkins@instructure.com>
Product-Review: Landon Wilkins <lwilkins@instructure.com>
QA-Review: Landon Wilkins <lwilkins@instructure.com>
Tested-by: Jenkins
  • Loading branch information
Ryan Shaw committed Aug 22, 2016
1 parent 876a515 commit cd03c7f
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion script/tatl_tael
Expand Up @@ -51,7 +51,14 @@ errors = []
linter.ban_new_erb do
errors << "Your commit includes new ERB files,"\
" which has been a no-no in Canvas since 2011."\
" All new UI should be built in React on top of documented APIs"
" All new UI should be built in React on top of documented APIs.\n"\
"Maybe try doing something like this in your controller instead:\n\n"\
" @page_title = t('Your Page Title')\n"\
" @body_classes << 'whatever-classes you-want-to-add-to-body'\n"\
" js_bundle :your_js_bundle\n"\
" css_bundle :any_css_bundles_you_want\n"\
" js_env({whatever: 'you need to put in window.ENV'})\n"\
" render :text => "".html_safe, :layout => true"\
end

linter.ensure_public_js_specs do
Expand Down

0 comments on commit cd03c7f

Please sign in to comment.