Discussion API doesn't process "pinned" field as boolean

[jessemcbride]

Summary:

I'm developing a Python wrapper for the API and I've noticed that the pinned field doesn't behave as expected when creating or updating a discussion topic. I have to explicitly send pinned as a lowercase "true" in my request, whereas every other endpoint I've covered evaluates to a boolean correctly no matter what the case is.

Steps to reproduce:

1. Send a POST request to /api/v1/courses/:course_id/discussion_topics containing the data published=True&pinned=True.
2. Notice that the topic is published successfully, but remains unpinned.

Request:

curl -X POST -H "Authorization: Bearer <snip>" -H "Cache-Control: no-cache" -H "Content-Type: multipart/form-data; boundary=----WebKitFormBoundary7MA4YWxkTrZu0gW" -F "pinned=True" -F "published=True" "<snip>/api/v1/courses/1195505/discussion_topics"

Response:

{
  "id": 3832190,
  "title": "No Title",
  <snip>
  "published": true,
  <snip>
  "pinned": false,
}

Expected behavior:

process_pin_parameters should operate consistently with the rest of the API. In particular, "True" should be evaluated as true and "False" should be evaluated as false.

Additional notes:

It seems value_to_boolean() could be used as it is in process_published_parameters to solve the problem.

[ccutrer]

I've already pushed up a fix internally, and it's been code reviewed, but not QA'd yet. Hopefully that happens in the next day or two, and this will make it into the 6/25 release.

[jessemcbride]

Sweet! Thanks @ccutrer.

[simonista]

fixed in 036c11c