Added ID into CustomColumn model so API documentation is accurate. #1224
Conversation
…ft description for teacher_notes blank.
|
|
|
Hey @justin0022 , thanks for your contribution! The "teacher_notes" column is the column that will be shown/hidden when a teacher selects to show/hide notes in the Gradebook (other custom columns will not be affected by this action). Maybe you can change the description to something like: "When true, this column's visibility will be toggled in the Gradebook when a user selects to show or hide notes" Once you've updated the description, I'll make sure this gets in front of the appropriate team for code review. Thanks, |
|
Hi @spencerolson, thanks! |
|
Hi @justin0022 , thanks for making that change :D I'll get this in front of devs for code review and keep you updated. |
|
Thanks @spencerolson! |
| @@ -26,6 +26,16 @@ | |||
| # "id": "CustomColumn", | |||
| # "description": "", | |||
| # "properties": { | |||
| # "id": { | |||
| # "description": "The ID of the custom gradebook column", | |||
| # "example": "2", | |||
There was a problem hiding this comment.
Hi @justin0022 , can you push up a new commit with this example value ("2") unquoted? Since it's an integer, we want to drop the quotes here in the example.
|
Hi @justin0022 , I left a comment on your commit. Can we unquote the example value ("2")? Once that's done, I think this will be ready to merge :D Thanks, |
|
Good point. I've made the change now. |
|
Wow! You're speedy. Thanks for doing that so quickly. Running it through tests again and then I think we'll be good-to-go. |
closes GH-1224 closes GRADE-824 Change-Id: Icf4ea1114d3e6661e775b424b2fb4cb186307f10 Reviewed-on: https://gerrit.instructure.com/139763 Tested-by: Jenkins Reviewed-by: Derek Bender <djbender@instructure.com> Reviewed-by: Jeremy Neander <jneander@instructure.com> QA-Review: Spencer Olson <solson@instructure.com> Product-Review: Keith T. Garner <kgarner@instructure.com>
|
Hi @justin0022 , your commit has been merged to the |
Left description for teacher_notes blank, as I don't know exactly what it does.