Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Spike sorting rerun #755

Merged
merged 58 commits into from
Jun 10, 2024
Merged

Spike sorting rerun #755

merged 58 commits into from
Jun 10, 2024

Conversation

chris-langfield
Copy link
Contributor

@chris-langfield chris-langfield commented Apr 10, 2024 •
edited
Loading

  • Add waveform extraction (code lives in ibl-neuropixel see extract_wf branch) to Spike Sorting task
  • Move EphysCellsQC into SpikeSorting

@chris-langfield chris-langfield changed the title add wf extraction to SpikeSorting task Spike sorting rerun Apr 10, 2024
chris-langfield and others added 28 commits April 10, 2024 12:29
@chris-langfield
ibl-neuropixel version
40ac2c6
@oliche
add the sync dataset in the spike sorting loader probe info
264f0c8
@GaelleChapuis
add keys
d15ca18
@GaelleChapuis
Merge branch 'gc_rp_refactor' into spikesorting_rerun
51f539e
@GaelleChapuis
add to metrics dict
9c0bd08
@chris-langfield
bitwise qc label
e7095c3
@oliche
reverse the bitwise qc labels so 0 is always passin
831becc
@chris-langfield
adjust wf extraction call
78b504a
@oliche
rename bitwise qc key
cb328d3
@oliche
fix test metrics
6d6f547
@oliche
Merge branch 'develop' into spikesorting_rerun
03e12d3
@chris-langfield
check for pyks import
27a082b
@oliche
add the cell qc computation at the spike sorting stage
9b43dd1
@chris-langfield
Merge branch 'spikesorting_rerun' of github.com:int-brain-lab/ibllib …
35881ef 
…into spikesorting_rerun
@chris-langfield
PopeyeDataHandler
6a6203d
@chris-langfield
add wf extraction to SpikeSorting task
ecbbef8
@chris-langfield
ibl-neuropixel version
cfd39de
@oliche @chris-langfield
add the sync dataset in the spike sorting loader probe info
32b2849
@GaelleChapuis @chris-langfield
add keys
0f5196c
@GaelleChapuis @chris-langfield
add to metrics dict
21efc1f
@chris-langfield
bitwise qc label
409f585
@oliche @chris-langfield
reverse the bitwise qc labels so 0 is always passin
096fd4c
@chris-langfield
adjust wf extraction call
9808192
@oliche @chris-langfield
rename bitwise qc key
9db9859
@oliche @chris-langfield
fix test metrics
6721b87
@chris-langfield
check for pyks import
30998ab
@oliche @chris-langfield
add the cell qc computation at the spike sorting stage
bfcdd8a
@chris-langfield
PopeyeDataHandler
66c0110
@oliche oliche closed this Jun 6, 2024
@oliche oliche reopened this Jun 6, 2024
@chris-langfield chris-langfield marked this pull request as ready for review June 7, 2024 15:03
@chris-langfield chris-langfield marked this pull request as draft June 7, 2024 15:47
@oliche oliche closed this Jun 9, 2024
@oliche oliche reopened this Jun 9, 2024
@oliche oliche closed this Jun 9, 2024
@oliche oliche reopened this Jun 9, 2024
@oliche oliche closed this Jun 10, 2024
@oliche oliche reopened this Jun 10, 2024
@oliche oliche closed this Jun 10, 2024
@oliche oliche reopened this Jun 10, 2024
@oliche oliche marked this pull request as ready for review June 10, 2024 15:48
@oliche oliche merged commit 0cfb83a into develop Jun 10, 2024
9 of 10 checks passed
@k1o0 k1o0 deleted the spikesorting_rerun branch September 19, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chris-langfield @oliche @GaelleChapuis