Unfurl: private links

[bkeepers]

A user sees an ephemeral prompt to verify that the private link should be unfurled (always, this time, never)
A user sees an unfurl of a private link.

Estimate: 2 weeks

Private unfurls are available via EARLY ACCESS

Read through this comment to find out how to get early access: #52 (comment)

Road to private unfurls

Things that need to be done before general availability:

• Persistent user settings Private unfurl user settings #528
• Better flow in case a user has not yet linked their GitHub account (building on top of Private unfurls: Prompt users to connect their GitHub account #536)
• Let users change settings using /github settings
• dm user if chat.ephemeral doesn't work because app is not in channel
  • Can we prompt users via additive permissions to add GitHub to the channel? Nope, not really :/
• Remove early access for private unfurls 🎉

[bkeepers]

Re-prioritizing as MUST (provided #53) based on our brief conversations about this last week.

[bkeepers]

@wilhelmklopp as we briefly discussed today, I don't think we're going to have time to get to this, so removing milestone for now. If we happen to have some free time next week we can revisit and get this deployed.

[olivierlacan]

I was a bit surprised when after subscribing a channel to a private repo, private URLs to code from that same repo weren't unfurled. That seemed like what this suggested:

It seems like until this feature is developed, the site should be updated to say "Public code snippets" to clarify. I wouldn't surprised if a lot of people made the same assumption I did and show up here to complain. 😄

Update: I didn't see any unfurling issue reported on https://status.slack.com/ at the time of this issue. And as a sidenote, repo commit notifications work fine in the channels I tested.

[brennaheaps]

@olivierlacan Hi! 👋

[bkeepers]

Thanks @olivierlacan. The copy did say "public" at one point, but it must have gotten dropped in one of the iterations.

Private unfurls are coming very soon.

[krumware]

+1 for confusing language, expected private repos to work.
Regardless, excited about this coming feature, thanks folks!

[bradical]

I had a question about how this will ultimately function. Will Private Repository unfurls depend on being subscribed to that repository in the channel or will it just use the perms of the authorizing user to determine access to the URL and could use any URL for any repo regardless of channel subscriptions?

[wilhelmklopp]

Will Private Repository unfurls depend on being subscribed to that repository in the channel or will it just use the perms of the authorizing user to determine access to the URL and could use any URL for any repo regardless of channel subscriptions?

It will most likely be based on the access of the user who posts the link. So any URL for any repo will work, but there may be an additional step where you need to confirm that you do want the link unfurled.

[bradical]

Thank you! Looking forward to this.

…

On Thu, Mar 1, 2018 at 07:39 Wilhelm Klopp ***@***.***> wrote: Will Private Repository unfurls depend on being subscribed to that repository in the channel or will it just use the perms of the authorizing user to determine access to the URL and could use any URL for any repo regardless of channel subscriptions? It will most likely be based on the access of the user who posts the link. So any URL for any repo will work, but there may be an additional step where you need to confirm that you do want the link unfurled. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#52 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALqnCo6bRKn9AGKFWUwMarbjxE8_oVkks5tZ-wKgaJpZM4QE6w_> .

[micahstubbs]

this would be incredibly useful. can't wait for this feature to land

[kooshywoosh]

+1 Looking forward to this as well

[micahstubbs]

would really like to see this land soon. is there anything that the community can do to help?

[deybhayden]

#522 looks to have been opened in the past 24 hours

[donbecker]

The PR referenced here was merged, has this been fixed/released?

[micahstubbs]

just tested this by pasting a private repo PR link into a slack channel with the github integration enabled. no unfurl for me, so doesn't seem to have been released widely yet.

hopefully it will be 🚢'd soon

[wilhelmklopp]

Early Access for Private Unfurls

Hey folks 👋
We're ready to open up the early access for private unfurls to anyone who is interested
@olivierlacan @krumware @bradical @micahstubbs @deybhayden @donbecker

What you need to do to be included

1. Agree to the pre-release agreement
2. Decided whether you want your entire Slack workspace early access enabled or only one channel
3. Provide us with your slack user id and either your team id or your channel id and contact support using this template
   • You can find out your Slack channel or team id using /github debug
4. We'll confirm via email when you're added
5. Post a private link in Slack and see it in action 🎉

Feedback

Have feedback for private unfurls? Thoughts on how it could be improved? We'd love to hear them! Please post feedback in this issue: #507

[bradical]

Awesome! Excited!

[krumware]

Thanks!!

[borekb]

Is this still invite / early access only? This announcement makes it sound like the feature is generally available but I'm not getting private repo previews even after removing and re-adding GitHub integration.

[rmccue]

@borekb You may need to /invite @github to the room as well.

[borekb]

I didn't realize I also need to enable access on GitHub's end; if only I read READMEs 🤦‍♂️ .

[wilhelmklopp]

As of last week, private unfurls are now generally available!

Thanks for your participation and feedback ✨

[iDVB]

@wilhelmklopp "generally available" meaning we need to follow the pre-release steps above or need only approve the default app?

I've only just approved the default app and /github subscribe blah/blah in our channel and we are not getting private unfurls. Which is how my googling brought me here.

[wilhelmklopp]

@iDVB that's correct. This should work automatically now. Could you double check that you're not encountering any of the things mentioned here and then write in at https://github.com/contact with the details of the problem you're seeing?

[billybooth]

Just to be clear, we should not be seeing unfurling for private commit links, correct? Are there any plans to support that? Rich link previews are behaving as expected for files, pull requests, etc. I thought this functionality was not behaving correctly, but I was using commit links to test. Thanks for your work on this. It's hugely beneficial to our team!

[wilhelmklopp]

Hey!

Yep, that's correct. We don't have previews for commit links yet. If this is something you want to work on, we'd be more than happy to accept that contribution :)

[lacostenycoder]

How do set up unfurl links to github issues on private repos???

[billybooth]

Basically just set up the integration using the instructions in the readme, sign in to GitHub via the integration as a user with access to the private repo, and attempt to post a link and unfurl it when prompted. IIRC, you’ll be redirected to GitHub and prompted to grant access to your repo. It’s pretty self-explanatory if you just try it.

[lacostenycoder]

@billybooth I did all of the above. We had had a github slack app installed for over 2 years. But I did the steps anyway. Still no unfurl. It works, and already did, with public repos. What am I missing?

[lacostenycoder]

Figured it out... it was a bit tricky, but I hacked it! LOL

[ninja-]

any plans for mattermost integration?