Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential memory leak in IntelDeflater #52

Closed
gspowley opened this issue Apr 2, 2017 · 3 comments
Closed

Potential memory leak in IntelDeflater #52

gspowley opened this issue Apr 2, 2017 · 3 comments
Assignees

Comments

@gspowley
Copy link
Contributor

gspowley commented Apr 2, 2017

We need to free the memory allocated for huffman tables on this line of IntelDeflater.cc, unless the ISA-L code is doing that for us.

@gspowley
Copy link
Contributor Author

gspowley commented Apr 3, 2017

@pnvaidya can you please take a look at this on Monday?

@pnvaidya
Copy link
Contributor

pnvaidya commented Apr 3, 2017

You are right, since we are allocating the tables in our code, we will have to clean it up, not ISAL…

if (level != 1) {
deflateEnd(lz_stream);
}
else
{
free(hufftables_custom);
free(lz_stream);
}

Let me add this change to existing pull request.

@gspowley
Copy link
Contributor Author

gspowley commented Apr 4, 2017

Resolved by #51

@gspowley gspowley closed this as completed Apr 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants