Skip to content
This repository has been archived by the owner on Apr 16, 2019. It is now read-only.

jq.ui.js bug in line 455 #49

Closed
jeffli opened this issue Jan 30, 2012 · 3 comments
Closed

jq.ui.js bug in line 455 #49

jeffli opened this issue Jan 30, 2012 · 3 comments

Comments

@jeffli
Copy link

jeffli commented Jan 30, 2012

Hi,

There is a bug in jq.ui.js line 455: if ($am(urlHash) !== null) { , I think it should be if ($am(urlHash) ) { because when I try to load a separate file from json, line 457 causes a js error because $am(urlHash) yields undefined and $am(urlHash) !== null is true, but that block shouldn't be executed.

Jeff

@imaffett
Copy link
Contributor

Thanks...I know it was like that originally, but one of the other core devs made the change. I'll try to figure out why.

Cam you also give us a test case (show the html you are using).

@jeffli
Copy link
Author

jeffli commented Jan 30, 2012

Hi, Ian

Here was what I did, I downloaded the appMobi-jQ.Mobi-89bdc57.zip and create a project from it in Chrome appMobi XDK. Then I experimented with loading pages from separated html files instead of in-page panels. I created a jqmui.html with following code:

<div title="jqUi" id="jqmui"  >


<h2 class='expanded' onclick='showHide(this,"jqui_info");'>jqUi</h2><p id='jqui_info'>jqUi is AppMobi's User Interface/User Experience library for mobile applications. It uses HTML5 and CSS3 for animations and transitions.<br />
We built the kitchen sink using jqUi.  It is comprised of components from the jqPlugins library and additional features.
<br>
    * Fixed navigation bar<br>
    * Auto scrolling content panels<br>
    * Optional footer to segment your application<br>
    </p>
    <ul>
    <li><a href="#jqmtransitions" >Transitions</a></li>
    <li><a href="#jqmforms" >Form Styles</a></li>
    <li><a href="#uiapi" >$.ui API</a></li>
    </ul>
</div>

then I changed index.html line 113 to

    <li><a href="jqmui.html" >jqUi</a></li>

to point to it. When I clicked jaUi tab, line 457 in jq.ui.js will yield a js error because $am(urlHash) is undefined.

Please let me know if anything I can help.

Jeff

@jeffli
Copy link
Author

jeffli commented Feb 1, 2012

thanks, Ian. I notice http://www.jqmobi.com/testdrive/index.html is already using the new 0.9.3 codebase. expecting the download ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants