Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/sysfs: drop discovery flags #1083

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

marquiz
Copy link
Contributor

@marquiz marquiz commented Jan 5, 2024

Simplify the code by dropping unused functionality. Effectively, we always used the default flags.

Depends on #1082

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (da26501) 32.11% compared to head (5c6eed8) 32.12%.
Report is 3 commits behind head on master.

Files Patch % Lines
pkg/cgroups/cgroupid.go 0.00% 2 Missing ⚠️
pkg/cri/resource-manager/cache/cache.go 0.00% 2 Missing ⚠️
pkg/cri/resource-manager/cache/container.go 0.00% 2 Missing ⚠️
pkg/cri/resource-manager/cache/utils.go 0.00% 1 Missing ⚠️
...ource-manager/control/page-migrate/page-migrate.go 0.00% 1 Missing ⚠️
...esource-manager/policy/builtin/balloons/cputree.go 0.00% 1 Missing ⚠️
pkg/dump/flags.go 0.00% 1 Missing ⚠️
pkg/instrumentation/flags.go 0.00% 1 Missing ⚠️
pkg/log/flags.go 0.00% 1 Missing ⚠️
pkg/log/grpc-logger.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1083   +/-   ##
=======================================
  Coverage   32.11%   32.12%           
=======================================
  Files          64       64           
  Lines        9938     9937    -1     
=======================================
  Hits         3192     3192           
+ Misses       6450     6449    -1     
  Partials      296      296           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

klihub
klihub previously approved these changes Jan 5, 2024
Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@klihub klihub dismissed their stale review January 5, 2024 13:16

The merge-base changed after approval.

Simplify the code by dropping unused functionality. Effectively, we
always used the default flags.
Copy link
Contributor

@klihub klihub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@klihub klihub merged commit ff17c2d into intel:master Jan 5, 2024
6 checks passed
Copy link
Contributor

@askervin askervin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marquiz marquiz deleted the devel/system-flags branch January 5, 2024 13:39
@marquiz marquiz mentioned this pull request Jan 8, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants