Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling of PAGE_FAULT_MASK #29

Closed
jposwiata opened this issue Sep 22, 2023 · 3 comments
Closed

Incorrect handling of PAGE_FAULT_MASK #29

jposwiata opened this issue Sep 22, 2023 · 3 comments
Assignees

Comments

@jposwiata
Copy link

The condition in core_interconnect.cpp:138 is incorrect. Should be:

if (is_finished && (status & 0x7f) == page_fault_mask)

(to get rid of READ/WRITE page fault bit, 0x80).
Same in :107

@jposwiata jposwiata changed the title Incorrect handling of PAGE_FAULTS Incorrect handling of PAGE_FAULT_MASK Sep 26, 2023
@abdelrahim-hentabli
Copy link
Contributor

Hey @jposwiata, thanks for opening this issue, and for sharing the fix as well. And great catch! We'll get this fixed ASAP!

@abdelrahim-hentabli abdelrahim-hentabli self-assigned this Oct 11, 2023
@abdelrahim-hentabli
Copy link
Contributor

Hey @jposwiata, thanks again for the issue, it should be fixed as of 673feec

@mzhukova
Copy link
Contributor

Closing as resolved and no reply from the submitter for a month.
@jposwiata please, feel free to re-open if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants