Add a port file to vcpkg?

[WeiDaiWD]

FYI, you can create a port file in vcpkg so that we can add a feature to SEAL:

./vcpkg install seal       # installs SEAL without HEXL
./vcpkg install seal[hexl] # installs SEAL with HEXL

[fboemer]

Thanks for the tip! This would be a nice feature; we'll take a look.

[WeiDaiWD]

Let me know if I can help.

[WeiDaiWD]

I took the liberty of adding "hexl" to vcpkg, See pull request.
We want to add "building APSI with HEXL enabled" to Microsoft/APSI's readme. Since we recommend building dependencies of APSI via vcpkg, we need HEXL to be there. :)

There are requirements in vcpkg that makes this PR really difficult. I'm working on it. Basically, HEXL's downloading cpu-features is not allowed in vcpkg, since the better way is to install cpu-features from vcpkg and to call find_package(CpuFeatures ...) in HEXL. But cpu-features installed by vcpkg has an issue too, which make find_package(CpuFeatures ...) fail all the time. I might have to add patches to both packages.

Anyway, nothing requires any change in HEXL so far. This is likely to be approved next week.

[fboemer]

I took the liberty of adding "hexl" to vcpkg, See pull request.
We want to add "building APSI with HEXL enabled" to Microsoft/APSI's readme. Since we recommend building dependencies of APSI via vcpkg, we need HEXL to be there. :)

There are requirements in vcpkg that makes this PR really difficult. I'm working on it. Basically, HEXL's downloading cpu-features is not allowed in vcpkg, since the better way is to install cpu-features from vcpkg and to call find_package(CpuFeatures ...) in HEXL. But cpu-features installed by vcpkg has an issue too, which make find_package(CpuFeatures ...) fail all the time. I might have to add patches to both packages.

Anyway, nothing requires any change in HEXL so far. This is likely to be approved next week.

Thanks, @WeiDaiWD! Let us know if you need any support from the hexl side.

[WeiDaiWD]

FYI, two minor things that I've noticed:

• cmake/HEXLConfig.cmakeis not ignored.
• HEXLConfig.cmake, HEXLConfigVersion.cmake, HEXLTargets.cmake, and HEXLTargets-release.cmake are installed to /usr/local/lib/cmake rather than /usr/local/lib/cmake/HEXL (or better /usr/local/lib/cmake/HEXL-1.1).

These are unrelated to this issue. :)

[WeiDaiWD]

Finally we have hexl added to vcpkg, this PR is merged. So now you can install hexl with ./vcpkg install hexl. On Windows, you have to use ./vcpkg install hexl:x64-windows-static or ./vcpkg install hexl:x64-windows-static-md. The reason why dynamic linking won't work on Windows is that HEXL does not export symbols.

I'm gonna add an option to install SEAL with HEXL enabled to vcpkg, e.g., ./vcpkg install seal[hexl] soon.

[fboemer]

Thanks, @WeiDaiWD! We'll see if we can fix the Windows dynamic build.

[WeiDaiWD]

No pressure. I was just describing what is supported when installing via vcpkg. SEAL does not support windows dynamic either. :)