Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Complete quoting for parameters of some CMake commands #1

Closed
elfring opened this issue Oct 21, 2015 · 1 comment
Closed

Complete quoting for parameters of some CMake commands #1

elfring opened this issue Oct 21, 2015 · 1 comment
Assignees
@mdb256

Comments

@elfring
Copy link

elfring commented Oct 21, 2015

Some parameters (like "${PROJECT_BINARY_DIR}/bin" and "${CMAKE_CURRENT_SOURCE_DIR}/autogen.py") are passed to CMake commands in your build scripts without enclosing them by quotation marks. I see that these places will result in build difficulties if the contents of the used variables will contain special characters like semicolons.

I would recommend to apply advices from a wiki article.
@mdb256 mdb256 self-assigned this Oct 22, 2015
@mdb256
Copy link

mdb256 commented Oct 30, 2015

Fixed in ba0b2b7

@mdb256 mdb256 closed this as completed Oct 30, 2015
@intel intel locked and limited conversation to collaborators Oct 30, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mdb256 mdb256

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elfring @mdb256