Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boost CMake not working #5

Closed
eplanet opened this issue Oct 24, 2015 · 2 comments
Closed

Boost CMake not working #5

eplanet opened this issue Oct 24, 2015 · 2 comments

Comments

@eplanet
Copy link

eplanet commented Oct 24, 2015

I think the working of CMake to find the Boost dependancy needs a little fix. While requiring a given version of boost is fine, suggesting to extract it in ${CMAKE_SOURCE_DIR}/include is not working. My understanding for the "hint" BOOST_INCLUDEDIR, is that is suggests to cmake to point to the required Boost installation in that directory, but not to search for the required headers inside that directory.

The proper way definitely seems to point to the boost headers using the BOOST_ROOT variable, and passing it to the script. The script's error message should then suggest the user to pass the following variable as an argument to CMake :
cmake .. -DBOOST_ROOT=/opt/boost_1_59_0/

The result is CMake working properly and making a symbolic link inside ${CMAKE_SOURCE_DIR}/include to /opt/boost_1_59_0/

P.S: There's a typo in the error message if boost is not found : "... Either install system pacakges if available ..."

@eplanet eplanet changed the title Boost CMake Boost CMake not working Oct 24, 2015
@mdb256
Copy link

mdb256 commented Oct 30, 2015

Thanks for this - fixed in ba0b2b7.

We use a symlink to the headers in include/boost on the vast majority of our testing machines, so we want to retain that method. We have added the description of BOOST_ROOT though as that is a good idea, and fixed a bug in the include_directories() call (_DIRS, not _DIR) so it should now actually work.

@mdb256 mdb256 closed this as completed Oct 30, 2015
@mdb256
Copy link

mdb256 commented Oct 30, 2015

But we missed the typo.

@mdb256 mdb256 reopened this Oct 30, 2015
@mdb256 mdb256 closed this as completed Oct 30, 2015
@intel intel locked and limited conversation to collaborators Aug 8, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants