Skip to content
This repository has been archived by the owner on Dec 14, 2022. It is now read-only.

Fix tests, doc and electron example after removing createCore API #41

Closed
huningxin opened this issue Dec 2, 2020 · 0 comments · Fixed by #42
Closed

Fix tests, doc and electron example after removing createCore API #41

huningxin opened this issue Dec 2, 2020 · 0 comments · Fixed by #42
Assignees
@artyomtugaryov
Labels
bug Something isn't working documentation Improvements or additions to documentation

Comments

@huningxin
Copy link
Contributor

After #39 merged, the createCore API is removed. There are some issues:

  • npm test fails, the test cases need to be fixed.

  • The API doc also to be fixed.

  • The electron example needs to be fixed.

@artyomtugaryov , please help. CC @lionkunonly .
@artyomtugaryov artyomtugaryov added bug Something isn't working documentation Improvements or additions to documentation labels Dec 2, 2020
@artyomtugaryov artyomtugaryov linked a pull request Dec 2, 2020 that will close this issue
Remove using createCore from documentation, tests and examples. Fix code style in examples #42
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@artyomtugaryov artyomtugaryov

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove using createCore from documentation, tests and examples. Fix code style in examples
2 participants
@huningxin @artyomtugaryov