-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crc: a proposal for implementation of crc test-case #67
Comments
@zhiyuan-zhu, thanks for proposal to add test cases. I agree the crc update test and sizes could be improved. The update test could take random fragment sizes for example. I'm not sure if reading data from a file will help since the program flow is completely feed-forward, the control flow of the program doesn't depend on the data. However we could model such as in igzip_rand_test.c where the data is either synthetically generated or taken from a file if provided. Also I don't think adding the table-driven comparisons in the test will speed up the tests. The reference functions are much slower, will dominate the time of the tests, and must be performed anyway. Adding another comparison will just slow the tests down and is really unnecessary if we also run the noarch tests. |
@gbtucker, thanks your suggestions, I will redesign this proposal. For "reading data from a file", I will refer to igzip_rand_test.c's design. I would like to create a new directory named: crc_stability_test in the crc/ directory, let this new test case not affect the original test case and as an option for users and developers. So the default original test case will still guarantee the correctness of the basic functions, this stability test case will just compare table-driven version with multi-binary version (not basic bit-wise version). |
@gbtucker, refine the proposal.
Would you like to accept this proposal or have any other suggestions? thanks! |
@zhiyuan-zhu I suggest we concentrate on test cases to improve coverage and not more comparisons. I think more cases and longer buffer sizes can still fit in the current "check" test. If test runtime is an issue then it can move to an extended test |
@gbtucker Thanks a lot, I will refine this proposal soon :). |
@gbtucker refine the proposal.
Do you have any other suggestions? |
@zhiyuan-zhu, I like 1, 2, & 5. Let's do those first. I'm not sure 3 & 4 add much. |
I have upload two documents,
detailed-design-doc.md.txt |
@gbtucker
This patch used to stress test for crc algorithm, especially the
clmul (carry-less multiplication instruction) optimized version.
More detailed, see the attachment file:
design-doc.md.txt
The text was updated successfully, but these errors were encountered: