Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that the Rust build script stays in sync with CMake configuration #36

Open
abrown opened this issue Dec 17, 2021 · 1 comment
Open

Comments

@abrown
Copy link
Contributor

abrown commented Dec 17, 2021

To avoid a cmake dependency, the Rust bindings (ittapi-rs) use direct cc commands in its build.rs script to build the ittnotify library. These cc commands could eventually get out of sync with the CMakeLists.txt configuration. To avoid this, we could add a CI step that builds the C library using cmake, builds the C library using the build.rs script, hash both libraries, and check that the results are the same. This depends on #17 being implemented.

@abrown
Copy link
Contributor Author

abrown commented Dec 17, 2021

cc: @jlb6740

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant