Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add vaSyncBuffer #408

Merged
merged 1 commit into from Jun 30, 2020
Merged

Add vaSyncBuffer #408

merged 1 commit into from Jun 30, 2020

Conversation

dmitryermilov
Copy link
Contributor

Signed-off-by: Dmitry Ermilov dmitry.ermilov@intel.com

@dmitryermilov dmitryermilov marked this pull request as draft May 8, 2020 12:08
xhaihao
xhaihao reviewed May 14, 2020
View reviewed changes
va/va_backend.h Show resolved Hide resolved
va/va.h Outdated Show resolved Hide resolved
@intel intel deleted a comment from XinfengZhang May 15, 2020
@dmitryermilov dmitryermilov force-pushed the vasyncbuffer branch 2 times, most recently from a9e21c1 to 3dab5de Compare May 18, 2020 13:55
@dmitryermilov dmitryermilov marked this pull request as ready for review May 18, 2020 15:27
xhaihao
xhaihao reviewed May 20, 2020
View reviewed changes
va/va.c Outdated Show resolved Hide resolved
@dmitryermilov dmitryermilov mentioned this pull request May 22, 2020
Closed
xhaihao
xhaihao approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@xhaihao xhaihao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryermilov
Copy link
Contributor Author

@dvrogozh , @xhaihao , @XinfengZhang , @dmitry-gurulev , @wyc55069407,

Please give your input: do we need VA_TIMEOUT_INFINITE here?

@wyc55069407
Copy link

@dvrogozh , @xhaihao , @XinfengZhang , @dmitry-gurulev , @wyc55069407,

Please give your input: do we need VA_TIMEOUT_INFINITE here?

same comments as in #407

@dmitryermilov dmitryermilov force-pushed the vasyncbuffer branch 2 times, most recently from de5443f to e3fb35a Compare June 28, 2020 13:48
@XinfengZhang
Copy link
Contributor

hi @dmitryermilov , LGTM, but it is new , which maybe will lead to different call sequence with before, could you help to add sample into libva-utils?

@dmitryermilov
Copy link
Contributor Author

hi @dmitryermilov , LGTM, but it is new , which maybe will lead to different call sequence with before, could you help to add sample into libva-utils?

Hi @XinfengZhang , yes, I can do it. Unfortunately libva-utils has only simple encode tools. I can replace vaSyncSurface with vaSyncBuffer e.g. in avcenc. But I have to say that, IMO, it won't be very descriptive for readers since the most benefits will be in 1->N cases. avcenc doesn't support it. I can do it after 1-2 weeks due to other commitments. libva and libva-utils are different repo's, I'd propose to merge current PR now (it's blocking other tasks). Is it okay for you?

XinfengZhang
XinfengZhang reviewed Jun 30, 2020
View reviewed changes
va/va.c Outdated Show resolved Hide resolved
@XinfengZhang XinfengZhang merged commit afca400 into intel:master Jun 30, 2020
@dmitryermilov
Add vaSyncBuffer for output buffers synchronization
5a0c289 
Added notes about different ways for synchronization.

Signed-off-by: Dmitry Ermilov <dmitry.ermilov@intel.com>
@dmitryermilov dmitryermilov deleted the vasyncbuffer branch June 30, 2020 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@XinfengZhang XinfengZhang XinfengZhang left review comments

@xhaihao xhaihao xhaihao approved these changes

@dvrogozh dvrogozh Awaiting requested review from dvrogozh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dmitryermilov @wyc55069407 @XinfengZhang @xhaihao