Skip to content

Add vaSyncSurface2 with timeout #407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

Add vaSyncSurface2 with timeout #407

merged 1 commit into from
Jun 23, 2020

Conversation

dmitryermilov
Copy link
Contributor

Fixes #397

Signed-off-by: Dmitry Ermilov dmitry.ermilov@intel.com

dvrogozh
dvrogozh requested changes Apr 22, 2020
View reviewed changes
@dmitryermilov dmitryermilov requested a review from dvrogozh April 23, 2020 09:12
@dmitryermilov dmitryermilov mentioned this pull request May 13, 2020
Closed
@dmitryermilov
Copy link
Contributor Author

@XinfengZhang , @dmitryermilov , do you have any other suggestions ?

dvrogozh
dvrogozh requested changes May 15, 2020
View reviewed changes
@dmitryermilov dmitryermilov requested review from dvrogozh and xhaihao May 15, 2020 15:48
xhaihao
xhaihao reviewed May 20, 2020
View reviewed changes
xhaihao
xhaihao approved these changes May 25, 2020
View reviewed changes
Copy link
Contributor

@xhaihao xhaihao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dmitryermilov
Copy link
Contributor Author

@dvrogozh , @xhaihao , @XinfengZhang , @dmitry-gurulev , @wyc55069407,

Please give your input: do we need VA_TIMEOUT_INFINITE here?

@wyc55069407
Copy link

@dvrogozh , @xhaihao , @XinfengZhang , @dmitry-gurulev , @wyc55069407,

Please give your input: do we need VA_TIMEOUT_INFINITE here?

I think VA_TIMEOUT_INFINITE can be defined as max(uint64_t) or uint64_t(-1) at va.h. And add comments in the new libva interface to show this value is specific to infinite.
(Like #define VA_TIMEOUT_INFINITE (0xffffffffffffffff))

When you updated va.h. i'll update intel/media-driver#943 & intel/media-driver#945

@wyc55069407 wyc55069407 mentioned this pull request May 29, 2020
Merged
@dmitryermilov
Add vaSyncSurface2 with timeout
4a2f9b0 
Fixes intel#397

Signed-off-by: Dmitry Ermilov <dmitry.ermilov@intel.com>
XinfengZhang
XinfengZhang approved these changes Jun 23, 2020
View reviewed changes
va/va.h
VAStatus vaSyncSurface2 (
VADisplay dpy,
VASurfaceID surface,
uint64_t timeout_ns
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we care about infinite wait? maybe int64_t is more suitable, negative value mean infinite?

@XinfengZhang XinfengZhang merged commit 3cc2212 into intel:master Jun 23, 2020
@dmitryermilov dmitryermilov mentioned this pull request Jun 23, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dvrogozh dvrogozh dvrogozh approved these changes

@xhaihao xhaihao xhaihao approved these changes

@XinfengZhang XinfengZhang XinfengZhang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enhance] Adding timeout for vaSyncSurface
5 participants
@dmitryermilov @wyc55069407 @dvrogozh @xhaihao @XinfengZhang