Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meson:remove autogen.sh from the meson script #821

Merged
merged 1 commit into from
Jun 20, 2024

Conversation

XinfengZhang
Copy link
Contributor

suppose no need to use customized package options. Fixes #804

@XinfengZhang
Copy link
Contributor Author

ping @eli-schwartz , please help to take a look.

@xhaihao
Copy link
Contributor

xhaihao commented Jun 18, 2024

LGTM.

@eli-schwartz
Copy link
Contributor

The purpose of that line was so that meson could be used to create dist tarballs (that contain a ./configure script). Removing this means that you cannot do meson dist and upload the resulting tarball as a universal release asset.

That may or may not be desirable. An alternative would be to include it via EXTRA_DIST.

suppose no need to use customized package options.
Fixes intel#804

Signed-off-by: Carl Zhang <carl.zhang@intel.com>
@XinfengZhang
Copy link
Contributor Author

The purpose of that line was so that meson could be used to create dist tarballs (that contain a ./configure script). Removing this means that you cannot do meson dist and upload the resulting tarball as a universal release asset.

thanks, so your initial purpose is adding the missing files into the tarball generated by meson dist, and these file are not using meson , but auto config. so it is not a universal release asset if there are no such files in the tarball.
but from another perspective. people should not expect to call autogen.sh if there are only meson.

That may or may not be desirable. An alternative would be to include it via EXTRA_DIST.

will you contribute a patch? suppose new patch will add missing files, but will not ask auto config support when run meson...

@eli-schwartz
Copy link
Contributor

will you contribute a patch? suppose new patch will add missing files, but will not ask auto config support when run meson...

Sure.

Note that meson only wants auto config support when running meson dist, it is simply that the helper script run during dist should always exist.

@XinfengZhang
Copy link
Contributor Author

XinfengZhang commented Jun 20, 2024

will you contribute a patch? suppose new patch will add missing files, but will not ask auto config support when run meson...

Sure.

Note that meson only wants auto config support when running meson dist, it is simply that the helper script run during dist should always exist.

thanks,

quick summary:
the origin issue #804 is caused by two problem:

  1. meson need autogen.sh when run "meson setup builddir", we are expecting it only be needed only when "meson dist"
  2. the autogen.sh is not existing in the tarball, because there are no such file in the tarball generated by "make dist-bzip2"

so, current patch could be used to hide the problem. until you have a official fix

@XinfengZhang XinfengZhang merged commit c7a4be4 into intel:master Jun 20, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Does not build: Program './autogen.sh' not found or not executable
3 participants