[SYCL][Reduction] Remove atomic64 check for float reductions
#6434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgorlani
added a commit
to pgorlani/llvm-test-suite
that referenced
this pull request
Jul 14, 2022
This patch refers to intel/llvm#6434
|
@aelovikov-intel - can you please review this patch as the only active developer of reduction these days? |
|
@v-klochkov do we require to run any performance tests before commit? |
pgorlani
force-pushed
the
remove-atomic64-check-for-f32-reductions
branch
from
26bedb6
to
6739e29
Compare
aelovikov-intel
previously approved these changes
Jul 25, 2022
|
Tag @steffenlarsen , in case you'd like to have a look as well. |
steffenlarsen
previously approved these changes
Jul 28, 2022
Co-authored-by: aelovikov-intel <andrei.elovikov@intel.com>
pgorlani
dismissed stale reviews from steffenlarsen and aelovikov-intel
via
934454b
pgorlani
force-pushed
the
remove-atomic64-check-for-f32-reductions
branch
from
6739e29
to
934454b
Compare
|
Thanks for your reviews, @steffenlarsen @aelovikov-intel! I rebased this PR onto the last refactoring of reductions, it should be fine. |
steffenlarsen
approved these changes
Jul 29, 2022
|
Thanks! |
aelovikov-intel
added a commit
to aelovikov-intel/llvm
that referenced
this pull request
Sep 27, 2022
intel#6434 enabled treating "float" as suitable for Reduction::has_fast_atomics implementation but that is slower than the one available under Reduction::has_fast_reduce. Make sure to check for the latter first.
steffenlarsen
pushed a commit
that referenced
this pull request
Sep 29, 2022
#6434 enabled treating "float" as suitable for Reduction::has_fast_atomics implementation but that is slower than the one available under Reduction::has_fast_reduce. Make sure to check for the latter first.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch
removes the check on
aspect::atomic64for reductions using atomic operations of single precision floating-point values. This solves sycl::reduction for float not working on AMD gpu #6054. However, it's not strictly necessary since also [SYCL][HIP] Implement PI_DEVICE_INFO_ATOMIC_64 for HIP #6429 solves it.adds the possibility of using
minandmaxatomic operations for reductions ofdoublevalues.