Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Enable Coveralls code coverage support. #165

Merged
merged 7 commits into from
Oct 14, 2021

Conversation

ossama-othman
Copy link
Member

No description provided.

@ossama-othman ossama-othman added the enhancement New feature or request label Oct 14, 2021
@ossama-othman ossama-othman added this to the Q4-2021 milestone Oct 14, 2021
@ossama-othman ossama-othman self-assigned this Oct 14, 2021
Ossama Othman added 3 commits October 14, 2021 12:14
The version of the AX_CODE_COVERAGE macro shipped with the version of
Ubuntu found in the GitHub Actions environment has a make variable
assignment problem that introduces a recursion related problem when
running "./configure --enable-code-coverage; make distcheck".  Package
the latest version of that macro with mptcpd to address that problem.
m4/ax_code_coverage.m4 Outdated Show resolved Hide resolved
Ossama Othman added 3 commits October 14, 2021 13:58
This reverts commit 3ec92af.

Opt for a separate coverage build that doesn't perform a distcheck to
avoid having to include a copy of ax_code_coverage.m4 in the source
distribution.
@ossama-othman
Copy link
Member Author

ossama-othman commented Oct 14, 2021

I probably should have pushed the m4/.gitignore file commit to a separate pull request. The m4 file removal earlier made me think of this file. Would you prefer a separate PR for it?

@mjmartineau
Copy link
Member

I don't see a need for a separate PR for gitignore changes

@ossama-othman ossama-othman merged commit f3bf5db into multipath-tcp:master Oct 14, 2021
@ossama-othman ossama-othman deleted the github-coveralls branch October 14, 2021 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants