Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: Attempt to work around coverage root path. #166

Merged
merged 3 commits into from
Oct 15, 2021

Conversation

ossama-othman
Copy link
Member

Coveralls isn't showing the source code if the user isn't logged in.
Attempt to work around the issue by setting source paths.

Coveralls isn't showing the source code if the user isn't logged in.
Attempt to work around the issue by setting source paths.
@ossama-othman ossama-othman added the bug Something isn't working label Oct 15, 2021
@ossama-othman ossama-othman self-assigned this Oct 15, 2021
@coveralls
Copy link

coveralls commented Oct 15, 2021

Pull Request Test Coverage Report for Build 1344590079

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 47.333%

Totals Coverage Status
Change from base Build 1343972186: 0.0%
Covered Lines: 914
Relevant Lines: 1931

💛 - Coveralls

Copy link
Member Author

@ossama-othman ossama-othman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source code is now visible on the Coveralls, but I'm not sure if this fixed pull request fixed the problem. At the very least it matches what the Coverall GitHub Action documentation suggests.

@ossama-othman ossama-othman merged commit 49d2280 into multipath-tcp:master Oct 15, 2021
@ossama-othman ossama-othman deleted the coveralls-path branch October 15, 2021 04:33
@ossama-othman
Copy link
Member Author

Source code is now visible on the Coveralls, but I'm not sure if this fixed pull request fixed the problem. At the very least it matches what the Coverall GitHub Action documentation suggests.

Scratch that. The problem still exists. Working on it ...

@ossama-othman
Copy link
Member Author

The Coveralls behavior we're seeing may be as designed: lemurheavy/coveralls-public#1579

@ossama-othman ossama-othman changed the title github: Attempt to work around Coveralls issue. github: Attempt to work around coverage root path. Oct 15, 2021
@mjmartineau
Copy link
Member

I logged in to Coveralls.io with my github credentials, and can see the line-by-line coverage view now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants