Correct mptcpd internal initialization order issues. #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ossama-othman
added
bug
Pull Request Test Coverage Report for Build 1400154986Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
ossama-othman
commented
Oct 29, 2021
| * | ||
| * @param[in] limits Array of MPTCP resource type/limit | ||
| * pairs. @c NULL on error. | ||
| * @param[in] len Length of the @a limits array. Zero | ||
| * on error. | ||
| * @param[in,out] callback_data Data provided by the caller of | ||
| * @c mptcpd_pm_get_limits(). | ||
| * @c mptcpd_kpm_get_limits(). | ||
| */ | ||
| typedef void (*mptcpd_pm_get_limits_cb)( | ||
| struct mptcpd_limit const *limits, |
There was a problem hiding this comment.
I'll probably rename this typedef to mptcpd_kpm_get_limits_cb_t in another pull request for the sake of consistency.
ossama-othman
commented
Oct 29, 2021
mjmartineau
reviewed
Oct 29, 2021
mjmartineau
approved these changes
Nov 2, 2021
added 16 commits
November 2, 2021 13:42
Introduce a new mptcpd_complete_func_t typedef to be used as the
paremeter type for functions to be called when a mptcpd asynchronous
call completes. That case is not the same as when asynchronous
results are available since results are not always available, but
completion always occurs.
Also introduce mptcpd_kpm_complete_func_t alias of
mptcpd_complete_func_t to be used specifically for mptcpd_{k}pm
related asynchronous functions, such as mptcpd_kpm_dump_addrs().
Lastly, rename mptcpd_pm_get_addr_cb to mptcpd_kpm_get_addr_cb_t, and
deprecate the former.
Leverage the newly added changes that allow the user to pass a function to be alled on completion of the mptcpd asynchronous path management operations, e.g. dump_addrs, to force correct initialization order of internal mptcpd path manager components. In particular, the dump_addrs call used to sync kernel/mptcpd state now completes before continuing with things like mptcpd plugin load. This allows internal mptcpd state to be stable and consistent prior plugin load, and before the "pm_ready" callback is triggered. MPTCP path management generic netlink event handlers are also now registered after plugins are loaded since there is no point handling events without the plugins.
This reverts commit 359e172.
This reverts commit b6315c9.
ossama-othman
force-pushed
the
async-complete-func
branch
from
59e4619
to
e6cbdb2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mptcpd synchronizes its internal state with the kernel at process start, and then continues with initialization such as plugin load and trigger the "pm_ready" callback. However, the kernel sync operation completes asynchronously meaning the kernel isn't actually "ready" when the plugins are loaded and "pm_ready" callback is triggered.
Introduce a new "
complete" function parameter to mptcpd path manager command functions that complete asynchronously, e.g.dump_addrs, that is called when the operation completes. The "complete" function differs from user provided callbacks that are called when asynchronous results are available in that it is called regardless of whether or not asynchronous results are available. Furthermore, they are only called once at the very end of the asynchronous call, whereas those called upon availability of results may be called multiple times for a single asynchronous call, such as the case fordump_addrs.Leverage the new "
complete" function parameter to force correct initialization order of internal mptcpd path manager components. In particular, thedump_addrscall used to sync kernel/mptcpd state now completes before continuing with things like mptcpd plugin load. This allows internal mptcpd state to be stable and consistent prior to plugin load, and before the "pm_ready" callback is triggered.MPTCP path management generic netlink event handlers are also now registered after plugins are loaded since there is no point handling events without the plugins.