You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed a memory leak inserted with the load-plugins options, where the plugins_to_load queue of the sys_config variable was not being destroyed on the mptcpd_config_create function.
Added a missing const qualifier to the input argument plugins of the set_plugins_to_load function.
This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Also, on the load_plugins function of the lib/plugin.h, since DIR *const ds = fdopendir(fd) is only used if it will load all the plugins it probably should be inside of the else statement right?
Also, on the load_plugins function of the lib/plugin.h, since DIR *const ds = fdopendir(fd) is only used if it will load all the plugins it probably should be inside of the else statement right?
There is no need to call close() on the file on the file descriptor
after a call to fdopendir(). closedir() is sufficient since
fdopendir() basically claims onwership of the file descriptor.
Calling close() after closedir() in this case actually results in a
EBADF error.
This reverts commit c6762cd.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a memory leak inserted with the load-plugins options, where the
plugins_to_loadqueue of thesys_configvariable was not being destroyed on themptcpd_config_createfunction.Added a missing
constqualifier to the input argumentpluginsof theset_plugins_to_loadfunction.Removed an extra space and dot on the man page.