Skip some tests on non-MPTCP kernels. #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 2, 2022 13:23
The mptcpd unit tests test-commands, test-path-manager and test-mptcpwrap require a MPTCP capable kernel to run. Make those tests return with an exit status (77) that causes the Automake test driver script, i.e. `test-driver' to treat the tests as skipped. This allows the test suite to succeed when MPTCP is not available in the kernel. The test summary from a `make check' run would look similar to the following when run on a non-MPTCP capable kernel: ... PASS: test-network-monitor SKIP: test-path-manager SKIP: test-commands PASS: test-configuration ... SKIP: test-mptcpwrap ========================================================================= Testsuite summary for mptcpd 0.9 ========================================================================= # TOTAL: 17 # PASS: 14 # SKIP: 3 # XFAIL: 0 # FAIL: 0 # XPASS: 0 # ERROR: 0 ========================================================================= Fixes #204.
|
@matttbe FYI. |
Pull Request Test Coverage Report for Build 1786364577Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
See Scripts-based Testsuites section in the Automake manual for details on test exit codes. |
mjmartineau
approved these changes
Feb 3, 2022
There was a problem hiding this comment.
Looks ok to me, might want confirmation from @matttbe before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mptcpd unit tests test-commands, test-path-manager and test-mptcpwrap require a MPTCP capable kernel to run. Make those tests return with an exit status (77) that causes the Automake test driver script, i.e. `test-driver' to treat the tests as skipped. This allows the test suite to succeed when MPTCP is not available in the kernel.
The test summary from a `make check' run would look similar to the following when run on a non-MPTCP capable kernel:
Fixes #204.