Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure: Improve MPTCP kernel detection. #218

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

ossama-othman
Copy link
Member

Detect a MPTCP capable kernel through the "enabled" file in
`/proc/sys/net/mptcp' rather than the <linux/mptcp.h> header alone if
the user hasn't chosen a specific MPTCP kernel, i.e. "upstream" or
"multipath-tcp.org". This allows mptcpd to be configured for the
multipath-tcp.org kernel by default if that kernel is at detected at
configure-time rather than always falling back on the upstream
kernel.

Previously, the `configure' script would by default fallback on the
upstream kernel support instead of the multipath-tcp.org kernel when
run on a distro using the latter.

Detect a MPTCP capable kernel through the "enabled" file in
`/proc/sys/net/mptcp' rather than the <linux/mptcp.h> header alone if
the user hasn't chosen a specific MPTCP kernel, i.e. "upstream" or
"multipath-tcp.org".  This allows mptcpd to be configured for the
multipath-tcp.org kernel by default if that kernel is at detected at
configure-time rather than always falling back on the upstream
kernel.

Previously, the `configure' script would by default fallback on the
upstream kernel support instead of the multipath-tcp.org kernel when
run on a distro using the latter.
@ossama-othman ossama-othman added the enhancement New feature or request label Feb 14, 2022
@ossama-othman ossama-othman added this to the Q1-2022 milestone Feb 14, 2022
@ossama-othman ossama-othman self-assigned this Feb 14, 2022
@coveralls
Copy link

coveralls commented Feb 14, 2022

Pull Request Test Coverage Report for Build 1839053315

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.266%

Totals Coverage Status
Change from base Build 1790578941: 0.0%
Covered Lines: 1060
Relevant Lines: 1990

💛 - Coveralls

Copy link
Member

@mjmartineau mjmartineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, successful build and test with both 5.16.8 (upstream, Fedora 35 distro kernel) and multipath-tcp.org (4.19.55), they were detected correctly.

@ossama-othman ossama-othman merged commit 310faef into multipath-tcp:master Feb 15, 2022
@ossama-othman ossama-othman deleted the cfg-kernel-detect branch February 15, 2022 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants