-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand mptcpd plugin framework code coverage #224
Expand mptcpd plugin framework code coverage #224
Conversation
Force plugin name-to-ops lookup to fail in the test-plugin unit test to excercise additional error paths.
Verify that mptcpd gracefully handles case where the plugin "init" function fails, i.e. returns a non-zero value.
Add network monitoring related callbacks to the noop test plugin.
Pull Request Test Coverage Report for Build 2146448568Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
The number of arguments passed when running plugin operation dispatch tests is large and a bit sloppy. Move the arguments used in the plugin operation dispatch tests to the new "plugin_call_args" struct to reduce clutter and make the code more manageable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me: code review, build & run on Fedora 35 (with code coverage).
No description provided.