Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand mptcpd plugin framework code coverage #224

Merged
merged 14 commits into from
Apr 14, 2022

Conversation

ossama-othman
Copy link
Member

No description provided.

@ossama-othman ossama-othman added this to the Q1-2022 milestone Mar 14, 2022
@ossama-othman ossama-othman self-assigned this Mar 14, 2022
@coveralls
Copy link

coveralls commented Mar 14, 2022

Pull Request Test Coverage Report for Build 2146448568

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+3.6%) to 57.365%

Files with Coverage Reduction New Missed Lines %
src/path_manager.c 1 14.15%
Totals Coverage Status
Change from base Build 1861888843: 3.6%
Covered Lines: 1145
Relevant Lines: 1996

💛 - Coveralls

Ossama Othman added 4 commits April 10, 2022 21:06
The number of arguments passed when running plugin operation dispatch
tests is large and a bit sloppy.  Move the arguments used in the
plugin operation dispatch tests to the new "plugin_call_args" struct
to reduce clutter and make the code more manageable.
@ossama-othman ossama-othman marked this pull request as ready for review April 11, 2022 20:05
@ossama-othman ossama-othman changed the title Expand mptcpd code coverage Expand mptcpd plugin framework code coverage Apr 11, 2022
Copy link
Member

@mjmartineau mjmartineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me: code review, build & run on Fedora 35 (with code coverage).

@ossama-othman ossama-othman merged commit e31ba5f into multipath-tcp:master Apr 14, 2022
@ossama-othman ossama-othman deleted the expand-coverage branch April 14, 2022 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants