Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: Fix gcc 12 link error. #226

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

ossama-othman
Copy link
Member

Declare inline functions with the static storage class to address
"undefined reference" link-time errors that occur when building mptcpd
with gcc-12.

Co-authored-by: Mat Martineau mathew.j.martineau@linux.intel.com

Declare inline functions with the static storage class to address
"undefined reference" link-time errors that occur when building mptcpd
with gcc-12.

Co-authored-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
@ossama-othman ossama-othman added the bug Something isn't working label Apr 7, 2022
@ossama-othman ossama-othman added this to the Q1-2022 milestone Apr 7, 2022
@ossama-othman ossama-othman self-assigned this Apr 7, 2022
@coveralls
Copy link

coveralls commented Apr 7, 2022

Pull Request Test Coverage Report for Build 2106528735

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 53.707%

Files with Coverage Reduction New Missed Lines %
src/path_manager.c 1 14.15%
Totals Coverage Status
Change from base Build 2005419859: -0.05%
Covered Lines: 1072
Relevant Lines: 1996

💛 - Coveralls

@ossama-othman
Copy link
Member Author

See GCC documentation on An Inline Function is As Fast As a Macro functions for related information on the static inline GCC C extension.

Copy link
Member

@mjmartineau mjmartineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with F36 beta and gcc 12, builds fine. Thanks!

@ossama-othman ossama-othman merged commit 3ff7bc8 into multipath-tcp:master Apr 7, 2022
@ossama-othman ossama-othman deleted the gcc-12 branch April 7, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants