Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sspi: Generate and remove MPTCP address ID as needed. #234

Closed
wants to merge 11 commits into from
Closed

sspi: Generate and remove MPTCP address ID as needed. #234

wants to merge 11 commits into from

Conversation

ossama-othman
Copy link
Member

No description provided.

@ossama-othman ossama-othman added bug Something isn't working enhancement New feature or request labels Jun 9, 2022
@ossama-othman ossama-othman self-assigned this Jun 9, 2022
@ossama-othman ossama-othman linked an issue Jun 9, 2022 that may be closed by this pull request
Support network monitoring in the "sspi" plugin #68
Open
@coveralls
Copy link

coveralls commented Jun 9, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3570409724

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 18 of 95 (18.95%) changed or added relevant lines in 1 file are covered.
  • 7 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-3.5%) to 61.475%
Changes Missing Coverage Covered Lines Changed/Added Lines %
plugins/path_managers/sspi.c 18 95 18.95%
Files with Coverage Reduction New Missed Lines %
src/path_manager.c 7 20.19%
Totals Coverage Status
Change from base Build 3490580438: -3.5%
Covered Lines: 1492
Relevant Lines: 2427
💛 - Coveralls

@mix-kao mix-kao mentioned this pull request Jun 14, 2022
Open
mjmartineau
mjmartineau reviewed Jun 14, 2022
View reviewed changes
Copy link
Member

@mjmartineau mjmartineau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small changes to suggest.

At first I was wondering if it makes sense for every plugin to explicitly handle the idm. I think it does, since customized plugins may want to ignore certain interfaces or have connection-specific handling of subflow ids.

plugins/path_managers/sspi.c Outdated Show resolved Hide resolved
include/mptcpd/path_manager.h Show resolved Hide resolved
@ossama-othman
Copy link
Member Author

Code coverage in the sspi plugin still isn't good since much of the sspi code requires network interfaces with the test addresses to be set up, similar to what is done in test-commands. Address/interface set up will be added in upcoming commits.

The addr_adv plugin is also loaded and run as a side effect of loading all plugins in the directory.

@ossama-othman ossama-othman mentioned this pull request Aug 8, 2022
Merged
Ossama Othman added 11 commits November 28, 2022 18:16
sspi: Create mptcpd local address ID manager.
16c5627 
Instantiate a mptcpd address ID manager to be used when mapping local
network interface IP addresses to MPTCP address IDs.
sspi: Add a more detailed plugin description.
83c7e40
include: Add missing <stdbool.h> include.
83463d2
sspi: Generate MPTCP address IDs as needed.
0a8596b
tests: Correct header include guard naming.
21642b7
sspi: Remove obsolete comment.
dbb8ce2
tests: Add a unit test for sspi plugin.
371f0a1 
A new unit test for the sspi plugin that simply exercises the the sspi
plugin operations.  Only blackbox testing is performed at this stage
since it is not straightforward to perform whitebox testing of the
sspi plugin internals.
sspi: Track new network interface as needed.
0c5aa0e 
Track the network interface associated with a new local address as
needed.
sspi: Draft impl for advertisment tracking.
03abb41
test-sspi: Add the missing server_side arguments.
83c1453 
Add the missing "server_side" arguments to the
mptcpd_plugin_new_connection() and
mptcpd_plugin_connection_established() function calls.
test-sspi: Only load the 'sspi' plugin.
a751ff8
@ossama-othman ossama-othman closed this by deleting the head repository Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjmartineau mjmartineau mjmartineau left review comments

Assignees

@ossama-othman ossama-othman

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support network monitoring in the "sspi" plugin
3 participants
@ossama-othman @coveralls @mjmartineau