network_monitor: Make test addrs static constants. #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 6, 2022 22:38
Make the mptcpd network monitor IPv4 and IPv6 "test net" addresses used for default route checks static constants to make sure they are initialized at compile-time instead of run-time. The MPTCPD_CONSTANT_HTONL() macro was used to allow the test IPv4 address to be initialized at compile-time. This also change also removes the re-initialization of the IPv4 test net address each time mptcpd network monitor operations are registered. Pre-change object file size (-O2 optimization): text data bss dec hex filename 10045 232 4 10281 2829 libmptcpd_la-network_monitor.o Post-change object file size (-O2 optimization): text data bss dec hex filename 10060 216 0 10276 2824 libmptcpd_la-network_monitor.o
Pull Request Test Coverage Report for Build 2627479281Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
mjmartineau
approved these changes
Jul 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the mptcpd network monitor IPv4 and IPv6 "test net" addresses used for default route checks
staticconstants to make sure they are initialized at compile-time instead of run-time.The
MPTCPD_CONSTANT_HTONL()macro was used to allow the test IPv4 address to be initialized at compile-time. This also change also removes the re-initialization of the IPv4 test net address each time mptcpd network monitor operations are registered.Pre-change object file size (-O2 optimization):
Post-change object file size (-O2 optimization):