include: Add MPTCPD_ADDR_FLAG_FULLMESH flag. #252
Conversation
Add per-endpoint in-kernel path management flags MPTCPD_ADDR_FLAG_FULLMESH and MPTCPD_ADDR_FLAG_IMPLICIT, corresponding to the kernel API flags MPTCP_PM_ADDR_FLAG_FULLMESH and MPTCP_PM_ADDR_FLAG_IMPLICIT, respectively.
Pull Request Test Coverage Report for Build 2829218048Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
include/mptcpd/types.h
Outdated
| * The in-kernel path manager may implictly create endpoints. Set | ||
| * this flag to allow user-provided endpoints to replace them. | ||
| */ | ||
| #define MPTCPD_ADDR_FLAG_IMPLICIT (1U << 4) |
There was a problem hiding this comment.
I could use another eye on the MPTCPD_ADDR_FLAG_FULLMESH and MPTCPD_ADDR_FLAG_IMPLICIT flag documentation. Both were based on git commit logs and the implementation of the corresponding kernel flags.
There was a problem hiding this comment.
MPTCPD_ADDR_FLAG_IMPLICIT is only set by the kernel when it creates implicit endpoints without userspace involvement.
The flag is not set by userspace when it tries to replace implicit endpoints. So, it only shows up as a possible attribute of a kernel-created endpoint, but it is not used when creating or replacing endpoints.
include/mptcpd/types.h
Outdated
| #define MPTCPD_ADDR_FLAG_SIGNAL (1U << 0) | ||
|
|
||
| /// Create a new subflow. | ||
| #define MPTCPD_ADDR_FLAG_SUBFLOW (1U << 1) | ||
|
|
||
| /// Set backup priority on the subflow. | ||
| #define MPTCPD_ADDR_FLAG_BACKUP (1U << 2) | ||
|
|
||
| /** | ||
| * @brief Add remote address to in-kernel fullmesh path management. |
There was a problem hiding this comment.
I think the most complete description of the fullmesh flag is in the iproute2 man ip mptcp page:
fullmesh
If this is a subflow endpoint and additional subflow creation is
allowed by the MPTCP limits, the MPTCP path manager will try to
create an additional subflow for each known peer address, using
this endpoint as the source address. This will occur after the
MPTCP connection is established. If the peer did not announce
any additional addresses using the MPTCP ADD_ADDR sub-option,
this will behave the same as a plain subflow endpoint. When the
peer does announce addresses, each received ADD_ADDR sub-option
will trigger creation of an additional subflow to generate a
full mesh topology.
(see https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/tree/man/man8/ip-mptcp.8#n165)
This @brief line should say this local address is the one added to in-kernel fullmesh path management.
include/mptcpd/types.h
Outdated
| /** | ||
| * @brief Add remote address to in-kernel fullmesh path management. | ||
| * | ||
| * Create a subflow for each remote address through the local address. |
There was a problem hiding this comment.
Suggested rephrasing: If this flag is set, create a subflow connection to each known remote address, originating from this local address. The total number of subflows is subject to the configured limits.
include/mptcpd/types.h
Outdated
| * The in-kernel path manager may implictly create endpoints. Set | ||
| * this flag to allow user-provided endpoints to replace them. | ||
| */ | ||
| #define MPTCPD_ADDR_FLAG_IMPLICIT (1U << 4) |
There was a problem hiding this comment.
MPTCPD_ADDR_FLAG_IMPLICIT is only set by the kernel when it creates implicit endpoints without userspace involvement.
The flag is not set by userspace when it tries to replace implicit endpoints. So, it only shows up as a possible attribute of a kernel-created endpoint, but it is not used when creating or replacing endpoints.
MPTCP_PM_ADDR_FLAG_IMPLICIT is only used internally by the kernel. Drop the corresponding mptcpd MPTCPD_ADDR_FLAG_IMPLICIT flag.
ossama-othman
changed the title
|
I updated the |
ossama-othman
force-pushed
the
update-addr-flags
branch
from
f864b6e
to
153ca15
Compare
Add per-endpoint in-kernel path management
MPTCPD_ADDR_FLAG_FULLMESHflag, correspondingto the kernel API flag
MPTCP_PM_ADDR_FLAG_FULLMESH.