Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve grep in entrypoint.sh to only find .conf and .conflist files #162

Conversation

Kusanagi9999
Copy link
Contributor

@Kusanagi9999 Kusanagi9999 commented Oct 5, 2018

the preivous grep expression will also find e.g. fooconffoo this one should only grab .conf and .conflist files ... I thought I had added this to my original PR but must have accidentally missed it.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 410

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 46.565%

Totals Coverage Status
Change from base Build 409: 0.0%
Covered Lines: 366
Relevant Lines: 786

💛 - Coveralls

@Kusanagi9999
Copy link
Contributor Author

@dougbtv ^^

@Kusanagi9999
Copy link
Contributor Author

Hey @dougbtv - I am working on a PR to add Multus to Kubespray (kubernetes-sigs/kubespray#3166). I'd like to use the image from https://hub.docker.com/r/nfvpe/multus/tags/. Do you think you could update latest once this has been merged? Also, is there an ETA for Multus v3.2?

@dougbtv
Copy link
Member

dougbtv commented Oct 10, 2018

@Kusanagi9999 -- sounds awesome re: Kubespray! Let me think about it a bit -- I wanted to have :latest be the latest stable (so I don't have to update the daemonset yaml often), and the images/image tags gets updated when we tag in the git rpeo, however... I think maybe what we could do is update the .travis.yml to also build a nfvpe/multus-latest image.

OR: I can manually tag an image for you and push it up to say, nfvpe/multus:v3.1.autoconf which includes this PR? Would that work in the meantime?

No solid date on a 3.2, however, it shouldn't be too long. I would guess within 30 days, we have a number of features we'll want in and tagged shortly, I'm sure of it.

Also, merging here in a moment! Sorry so slow getting back to this PR, been on the road.

@dougbtv dougbtv merged commit 1caddae into k8snetworkplumbingwg:master Oct 10, 2018
@Kusanagi9999
Copy link
Contributor Author

@dougbtv, OK got it, nfvpe/multus:v3.1.autoconf would totally work for now until v3.2 is out. Thanks a lot!

pliurh pushed a commit to pliurh/multus-cni that referenced this pull request Sep 22, 2023
…f-fix-414

OCPBUGS-13815: Fix multus to support CNI plugin which does not create interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants